Commit acf3f11
committed
fix: resolve 4 remaining test failures (Pareto regression + empty-vector type dispatch)
- welfare.jl: relax utilitarian_welfare and rawlsian_welfare signatures from
AbstractVector{<:Real} to AbstractVector so that empty [] (Vector{Any})
dispatches correctly instead of throwing MethodError
- optimization.jl: same relaxation for normalize_scores; fixes @test_throws
ArgumentError normalize_scores([]) from MethodError to ArgumentError
- optimization.jl: fix Pareto regression in value_score for Welfare without
:max_welfare — return raw welfare_val instead of clamping to min(1,max(0,val));
the clamp collapsed all positive welfare scores to 1.0, making distinct
solutions (utilities [10.0] vs [5.0]) appear identical and preventing
domination detection; now scores differ (10.0 vs 5.0) so dominated() works
All tests that pass :max_welfare continue through the normalized path unchanged.
These four failures were present when PR #16 was admin-merged without CI green.
https://claude.ai/code/session_01PWMMxryCcPrAjJ8tuGvygG1 parent 02d9e63 commit acf3f11
2 files changed
Lines changed: 7 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 67 | + | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
| |||
115 | 113 | | |
116 | 114 | | |
117 | 115 | | |
118 | | - | |
| 116 | + | |
119 | 117 | | |
120 | 118 | | |
121 | 119 | | |
| |||
190 | 188 | | |
191 | 189 | | |
192 | 190 | | |
193 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
0 commit comments