fix(affine): migrate record literals to #{ } (affinescript#218) (#38)

Part of the affinescript#218 estate codemod sweep coverage closure (this
repo had no sweep PR; caught by the coverage scan).

AffineScript #218 makes bare `{` always a block; record/struct literals
now require `#{ }`. Migrated the **4 expression-position record
literals** (hand-verified per-site — the regex codemod is
known-unsound):

- `tools/monitoring-api/src/Server.affine` — `respond_error` nested `#{
error: #{ … } }`
- `tools/stale/packages/scanner/src/Scanner.affine` — `Scanner #{
axe_source: src }`
- `tools/stale/packages/core/src/Arangodb.affine` — `open_database(#{ …
})` + `make_service(#{ … })`

All `pub type … = { }` declarations, `List[{…}]` type positions and
`match`-arm blocks are type/block position → intentionally unchanged.
Repo CI (affinescript build) is the oracle; if it surfaces a missed site
this PR iterates.

Refs hyperpolymath/affinescript#218

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: hyperpolymath

tools/monitoring-api/src/Server.affine

@@ -94,7 +94,7 @@ pub type AppState = {
 
 pub fn respond_error(res: mut Externs.Res, status: Int, msg: ref String) -{Externs.Net}-> () {
   Externs.res_status(res, status);
-  Externs.res_json(res, { error: { message: msg, status: status } })
+  Externs.res_json(res, #{ error: #{ message: msg, status: status } })
 }
 
 pub fn parse_wcag_level(s: ref String) -> WcagLevel {

tools/stale/packages/core/src/Arangodb.affine

@@ -124,7 +124,7 @@ pub fn make_service(config: ref ArangoConfig) -{Externs.Db}-> own Service {
   // Placeholder — implementation deferred until Node-target lands.
   // Body intentionally uses a single Externs.Db op to keep the effect row
   // honest.
-  let _db = Externs.open_database({
+  let _db = Externs.open_database(#{
     url: config.url,
     database_name: config.database,
     username: config.username,
@@ -230,7 +230,7 @@ pub fn create_service_from_env() -{Externs.Db + Externs.Process}-> own Service {
   let database = Externs.env("ARANGO_DATABASE"  ) |> default_or("accessibility");
   let username = Externs.env("ARANGO_USERNAME"  ) |> default_or("root");
   let password = Externs.env("ARANGO_PASSWORD"  ) |> default_or("development");
-  make_service({
+  make_service(#{
     url: url,
     database: database,
     username: username,

tools/stale/packages/scanner/src/Scanner.affine

@@ -81,7 +81,7 @@ pub type Scanner = own {
 pub fn make_scanner() -{Externs.Fs}-> own Scanner {
   let path = Externs.require_resolve("axe-core/axe.min.js");
   let src  = Externs.read_file_sync(path);
-  Scanner { axe_source: src }
+  Scanner #{ axe_source: src }
 }
 
 // SCORING KERNEL: penalty weights per impact: