Skip to content

Commit 48ef42f

Browse files
chore: refresh stale CI notes + sync drifted Deno fixtures (#608)
Optional housekeeping from the #138 / standalone-CI thread. Docs + regenerated test fixtures only — no source change. ### 1. `.claude/CLAUDE.md` — refresh the stale "known-failing baseline checks" Now that CI is standalone + green on `main` (#604), several entries were out of date: - `vscode-smoke` → **now passes** (self-contained; skips cleanly without the optional npm package). - `migration-assistant` → **passes on current `main`** (only red on pre-#342 bases). - `governance` → replaced by the self-contained local gate (`tools/ci/governance-standalone.sh`); the old estate `Language / package anti-pattern policy` sub-check no longer runs. - Hypatia comment counts refreshed (~43–71); clarified it's a *delta in your changed files* that matters, and the Hypatia *check* gates separately (green). - Recorded the two `startup_failure` classes that bit the repo for days so they aren't reintroduced: **(1)** the Actions "allowed actions" policy rejects **tag-pinned** refs at run-creation → pin every `uses:` to a full SHA; **(2)** BP008 reusable-caller `concurrency:` stacking. ### 2. `tests/codegen-deno/*.deno.js` — sync 3 drifted snapshots 3 of 30 committed Deno-ESM snapshots had drifted from current codegen output (runtime-preamble evolution — WASI `fd_write` import, pixi/ipc bindings); regenerated. All deno harnesses still pass under node. ### Verified `dune test` green · `tools/run_codegen_deno_tests.sh` all harnesses pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Lz7pRcec2Z3tVtaAhvB3M8 --- _Generated by [Claude Code](https://claude.ai/code/session_01Lz7pRcec2Z3tVtaAhvB3M8)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2efe0e3 commit 48ef42f

4 files changed

Lines changed: 539 additions & 21 deletions

File tree

.claude/CLAUDE.md

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -230,24 +230,35 @@ not the log content. The fast paths for an agent are:
230230
`gh run view --log-failed <run-id>`; do not loop trying to scrape
231231
the UI.
232232

233-
### Known-failing baseline checks
234-
235-
These checks currently fail on *every* PR for repo-wide reasons, not
236-
because of any individual PR's changes. Do not waste turns
237-
investigating them on a per-PR basis:
238-
239-
* `vscode-smoke` — npm 404 on `@hyperpolymath/affine-vscode` (the
240-
in-editor harness depends on a not-yet-published npm package).
241-
* `migration-assistant` — was fixed by #342, but any branch created
242-
from a base older than #342 will still see it red until rebased.
243-
* `governance / Language / package anti-pattern policy` — flags the
244-
approved TypeScript exemptions (`affinescript-deno-test/*.ts`,
245-
`editors/vscode/test/*.js`, etc., all documented in this file's
246-
exemptions tables); the check has no allowlist for them.
247-
* The Hypatia security-scan bot comment — 143 findings; the bulk are
248-
the same TypeScript exemption hits + pre-existing root files. A
249-
real new finding will show as a *delta* in the count; otherwise
250-
ignore.
233+
### Known-failing baseline checks — updated 2026-06-20
234+
235+
Historically these failed on *every* PR for repo-wide reasons. Most are now
236+
resolved; kept here with current status so agents don't re-investigate:
237+
238+
* `vscode-smoke`**now passes**. Self-contained since the codegen-embed fix
239+
(skips cleanly when the optional `@hyperpolymath/affine-vscode` npm package
240+
is absent). The old "npm 404 fails every PR" no longer holds.
241+
* `migration-assistant`**passes on current `main`**; only red on branches
242+
based before #342. Rebase to clear.
243+
* `governance` — replaced (#603/#604) by a self-contained local gate
244+
(`tools/ci/governance-standalone.sh`); the old estate
245+
`Language / package anti-pattern policy` sub-check (from the
246+
`hyperpolymath/standards` reusable) no longer runs.
247+
* The Hypatia security-scan bot *comment*~43–71 findings depending on scan
248+
scope; the bulk are the documented TypeScript/JS exemptions + pre-existing
249+
root files. A real new finding shows as a *delta in your changed files*;
250+
otherwise ignore. (The Hypatia *check run* gates separately and is green.)
251+
252+
**CI is now standalone and green on `main` (since #604 / `c7922cf`).** Two
253+
`startup_failure` classes bit `ci` / `governance` / `secret-scanner` for days
254+
(and `main` itself) — worth knowing so they aren't reintroduced:
255+
256+
1. The repo's Actions "allowed actions" policy **rejects tag-pinned action
257+
refs at run-creation** (a `startup_failure` with zero jobs). **Pin every
258+
`uses:` to a full commit SHA**`actions/foo@v4` will fail to start.
259+
2. A reusable-workflow *caller* that declares `concurrency:` on the same key
260+
the reusable also declares is rejected at run-creation (BP008 — see
261+
`.github/workflows/spark-theatre-gate.yml`).
251262

252263
If a check from this list *changes status* on a PR (e.g.
253264
`vscode-smoke` suddenly passes, or Hypatia surfaces a new class of

tests/codegen-deno/bytes_binary_io.deno.js

Lines changed: 170 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)