feat(vscode-bindings): expand surface for rsr-certifier port (#64) (#102)

* feat(vscode-bindings): expand surface for rsr-certifier port (#64)

Adds ~20 new extern fns + 5 opaque handle types to stdlib/Vscode.affine
and their JS-side implementations to packages/affine-vscode/mod.js, so
the rsr-certifier extension in hyperpolymath/standards can be ported
to .affine with full feature parity (issue #64 acceptance bullet 2).

Bindings added — see stdlib/Vscode.affine for shapes:

  Workspace:
    workspaceFolderFirstPath, workspaceRootUri

  Uri / file-system / text documents:
    uriFromPath, uriJoinPath, uriPath,
    fsWriteFile, openTextDocument, showTextDocument

  Status bar:
    createStatusBarItem + setText / setTooltip / setCommand /
    setBackgroundColorTheme / show / hide / asDisposable

  Diagnostics (JSON-shaped to avoid Range/Diagnostic struct FFI):
    createDiagnosticCollection + clear / setForUri / asDisposable

  Webview:
    createWebviewPanel + setHtml / asDisposable

  Clipboard:
    clipboardWriteText

  Events:
    onDidSaveTextDocument (handler is a zero-arg wasm-table thunk; the
    TextDocument arg from the underlying vscode event is dropped at the
    FFI boundary — handlers that need the saved file path can call
    editorActiveFilePath() inside the thunk)

  Path helpers / process / context:
    pathBasename, pathJoin, processPlatform, extensionAbsolutePath

New opaque types: StatusBarItem, DiagnosticCollection, WebviewPanel,
Uri, TextDocument.

Two API shapes deliberately omitted because they require an async-extern
ABI that doesn't exist yet:

  vscode.window.withProgress(opts, async task) -- task is Thenable-returning.
  LanguageClient.sendRequest(method, params)    -- returns a Thenable.

Extensions that need either should fall back to terminal / execSync
shells until async externs land. Both omissions are noted in
stdlib/Vscode.affine and in packages/affine-vscode/README.adoc.

Verification:

  $ AFFINESCRIPT_STDLIB=$PWD/stdlib affinescript compile \
      /tmp/test-new-bindings.affine -o /tmp/test-bindings.cjs
  Compiled ... -> /tmp/test-bindings.cjs (Node-CJS)

A smoke-test .affine exercising every new binding compiles cleanly via
the existing affinescript compiler — no codegen changes needed; the
new symbols flow through the existing extern-resolution + Wasm-import-
emission paths.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fixup: add stringIsEmpty helper (used by rsr-certifier no-workspace checks)

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: hyperpolymath

packages/affine-vscode/README.adoc

@@ -36,17 +36,43 @@ adapter._extraImports = () => makeBindings(vscode, lc, () => instance);
 
 The adapter implements every `extern fn` declared in:
 
-* `stdlib/Vscode.affine` — 11 bindings covering vscode.commands.registerCommand,
+* `stdlib/Vscode.affine` — initial set (issue #35 Phase 2): commands.registerCommand,
   workspace.getConfiguration / createFileSystemWatcher,
-  window.showErrorMessage / showWarningMessage / showInformationMessage,
+  window.{showError,showWarning,showInformation}Message,
   window.createTerminal + terminal.show / sendText,
-  ExtensionContext.subscriptions.push, and window.activeTextEditor.
+  ExtensionContext.subscriptions.push, window.activeTextEditor,
+  editorActive{FilePath,LanguageId}, workspaceConfigGet{Bool,String},
+  consoleLog, execSync, and three string helpers.
++
+Expanded 2026-05-11 for the rsr-certifier port (issue #64):
+workspaceFolderFirstPath / workspaceRootUri, uriFromPath / uriJoinPath / uriPath,
+fsWriteFile, openTextDocument / showTextDocument,
+createStatusBarItem + statusBarItem.{setText,setTooltip,setCommand,setBackgroundColorTheme,show,hide,asDisposable},
+createDiagnosticCollection + diagnosticCollection.{clear,setForUri,asDisposable},
+createWebviewPanel + webviewPanel.{setHtml,asDisposable},
+clipboardWriteText, onDidSaveTextDocument,
+pathBasename / pathJoin / processPlatform, and extensionAbsolutePath.
+
 * `stdlib/VscodeLanguageClient.affine` — 3 bindings covering
   new LanguageClient(...) / start() / stop().
 
+== Deliberate omissions
+
+Two API shapes are not bound because they cannot be expressed in the
+current synchronous extern-call ABI without an async-extern hookup:
+
+* `vscode.window.withProgress(opts, async task)` — the second arg is an
+  async Thenable-returning task.
+* `LanguageClient.sendRequest(method, params)` — returns a Thenable.
+
+Extensions that need either should fall back to shelling out to a CLI
+via `Vscode::createTerminal` / `Vscode::execSync` until an async-extern
+ABI lands.
+
 == Design notes
 
-* All host objects (Disposable, Terminal, ExtensionContext, ...) are
+* All host objects (Disposable, Terminal, ExtensionContext, StatusBarItem,
+  DiagnosticCollection, WebviewPanel, Uri, TextDocument, ...) are
   represented as opaque integer handles on both sides of the FFI. The
   adapter maintains a JS-side handle table.
 * String args are passed across as i32 pointers into the wasm linear
@@ -55,9 +81,14 @@ The adapter implements every `extern fn` declared in:
 * Wasm function-pointer args (e.g. command handlers) come in as
   `__indirect_function_table` indices; the adapter wraps each in a JS
   thunk that re-enters the wasm module on invocation.
+* Diagnostics avoid a Range+Diagnostic struct FFI by accepting a JSON
+  array: `[{startLine,startCol,endLine,endCol,message,severity}, ...]`.
+  The adapter parses it and constructs the vscode objects.
 
 == Status
 
-Phase 2 — bindings landed. Phase 3 (`editors/vscode/src/extension.ts` →
-`editors/vscode/src/extension.affine` rewrite) is the next milestone. Phase 4
-sweeps the rattlescript-face copy.
+Phase 2 — bindings landed. The pilot affinescript port (issue #63) and
+external-extension ports (issue #64: my-lang, rsr-certifier) consume
+this adapter; the long-term plan is to publish it to npm so consumers
+do not have to vendor `mod.js`. Phase 4 (rattlescript-face sweep) still
+to do.

packages/affine-vscode/mod.js

@@ -150,6 +150,174 @@ module.exports = function makeVscodeBindings(vscode, lcModule, hostShim) {
       const out = s.endsWith(suffix) ? s.slice(0, -suffix.length) + replacement : s;
       return reg(out);
     },
+    stringIsEmpty: (sPtr) => readString(sPtr).length === 0 ? 1 : 0,
+
+    // ── Workspace ───────────────────────────────────────────────────
+    workspaceFolderFirstPath: () => {
+      const folders = vscode.workspace.workspaceFolders;
+      const first = folders && folders[0];
+      return reg(first ? first.uri.fsPath : "");
+    },
+    workspaceRootUri: () => {
+      const folders = vscode.workspace.workspaceFolders;
+      const first = folders && folders[0];
+      return first ? reg(first.uri) : 0;
+    },
+
+    // ── URI / file-system / text documents ─────────────────────────
+    uriFromPath: (pathPtr) => reg(vscode.Uri.file(readString(pathPtr))),
+    uriJoinPath: (baseHandle, segPtr) => {
+      const base = get(baseHandle);
+      if (!base) return 0;
+      return reg(vscode.Uri.joinPath(base, readString(segPtr)));
+    },
+    uriPath: (uHandle) => {
+      const u = get(uHandle);
+      return reg(u ? u.fsPath : "");
+    },
+    fsWriteFile: (uHandle, contentPtr) => {
+      const u = get(uHandle);
+      if (!u) return 1;
+      try {
+        // Fire-and-forget the Thenable. The host serialises FS ops so
+        // a subsequent openTextDocument on the same URI sees the file.
+        vscode.workspace.fs.writeFile(u, Buffer.from(readString(contentPtr)));
+        return 0;
+      } catch (e) {
+        return 1;
+      }
+    },
+    openTextDocument: (uHandle) => {
+      const u = get(uHandle);
+      if (!u) return 0;
+      // openTextDocument returns a Thenable<TextDocument>. The synchronous
+      // FFI returns a handle to the Thenable itself; showTextDocument is
+      // also Thenable-returning and chains via vscode's internal queue,
+      // so this works in practice for the open-then-show pattern.
+      return reg(vscode.workspace.openTextDocument(u));
+    },
+    showTextDocument: (dHandle) => {
+      const d = get(dHandle);
+      if (!d) return 1;
+      // If `d` is itself a Thenable<TextDocument>, vscode unwraps it.
+      Promise.resolve(d).then((doc) => vscode.window.showTextDocument(doc));
+      return 0;
+    },
+
+    // ── Status bar ─────────────────────────────────────────────────
+    createStatusBarItem: (alignment, priority) => {
+      const align = alignment === 1
+        ? vscode.StatusBarAlignment.Right
+        : vscode.StatusBarAlignment.Left;
+      return reg(vscode.window.createStatusBarItem(align, priority));
+    },
+    statusBarItemSetText: (sHandle, tPtr) => {
+      const s = get(sHandle);
+      if (s) s.text = readString(tPtr);
+      return 0;
+    },
+    statusBarItemSetTooltip: (sHandle, tPtr) => {
+      const s = get(sHandle);
+      if (s) s.tooltip = readString(tPtr);
+      return 0;
+    },
+    statusBarItemSetCommand: (sHandle, cPtr) => {
+      const s = get(sHandle);
+      if (s) s.command = readString(cPtr);
+      return 0;
+    },
+    statusBarItemSetBackgroundColorTheme: (sHandle, cPtr) => {
+      const s = get(sHandle);
+      if (!s) return 0;
+      const name = readString(cPtr);
+      s.backgroundColor = name.length === 0 ? undefined : new vscode.ThemeColor(name);
+      return 0;
+    },
+    statusBarItemShow: (sHandle) => { const s = get(sHandle); if (s) s.show(); return 0; },
+    statusBarItemHide: (sHandle) => { const s = get(sHandle); if (s) s.hide(); return 0; },
+    statusBarItemAsDisposable: (sHandle) => sHandle, // same JS object is a Disposable
+
+    // ── Diagnostics ────────────────────────────────────────────────
+    createDiagnosticCollection: (namePtr) =>
+      reg(vscode.languages.createDiagnosticCollection(readString(namePtr))),
+    diagnosticCollectionClear: (cHandle) => {
+      const c = get(cHandle);
+      if (c) c.clear();
+      return 0;
+    },
+    diagnosticCollectionSetForUri: (cHandle, uHandle, jsonPtr) => {
+      const c = get(cHandle);
+      const u = get(uHandle);
+      if (!c || !u) return 1;
+      let arr;
+      try { arr = JSON.parse(readString(jsonPtr)); }
+      catch (e) { return 2; }
+      if (!Array.isArray(arr)) return 3;
+      const diagnostics = arr.map((d) => {
+        const range = new vscode.Range(
+          d.startLine | 0, d.startCol | 0,
+          d.endLine | 0, d.endCol | 0
+        );
+        const severity = [
+          vscode.DiagnosticSeverity.Error,
+          vscode.DiagnosticSeverity.Warning,
+          vscode.DiagnosticSeverity.Information,
+          vscode.DiagnosticSeverity.Hint,
+        ][Math.max(0, Math.min(3, d.severity | 0))];
+        return new vscode.Diagnostic(range, String(d.message ?? ""), severity);
+      });
+      c.set(u, diagnostics);
+      return 0;
+    },
+    diagnosticCollectionAsDisposable: (cHandle) => cHandle,
+
+    // ── Webview ────────────────────────────────────────────────────
+    createWebviewPanel: (vtPtr, titlePtr, vc) => {
+      const viewColumn =
+        vc === 2 ? vscode.ViewColumn.Two :
+        vc === 3 ? vscode.ViewColumn.Three :
+        vscode.ViewColumn.One;
+      return reg(vscode.window.createWebviewPanel(
+        readString(vtPtr), readString(titlePtr), viewColumn, {}
+      ));
+    },
+    webviewPanelSetHtml: (pHandle, htmlPtr) => {
+      const p = get(pHandle);
+      if (p) p.webview.html = readString(htmlPtr);
+      return 0;
+    },
+    webviewPanelAsDisposable: (pHandle) => pHandle,
+
+    // ── Clipboard ──────────────────────────────────────────────────
+    clipboardWriteText: (tPtr) => {
+      try {
+        vscode.env.clipboard.writeText(readString(tPtr));
+        return 0;
+      } catch (e) {
+        return 1;
+      }
+    },
+
+    // ── Events ─────────────────────────────────────────────────────
+    onDidSaveTextDocument: (handlerIdx) => {
+      const thunk = wrapHandler(handlerIdx);
+      // The vscode event ships a TextDocument; we deliberately drop it at
+      // the FFI boundary (see Vscode.affine docstring). Handlers that
+      // need the saved file path can call editorActiveFilePath().
+      return reg(vscode.workspace.onDidSaveTextDocument(() => thunk()));
+    },
+
+    // ── Path helpers ───────────────────────────────────────────────
+    pathBasename: (pPtr) => reg(require("path").basename(readString(pPtr))),
+    pathJoin: (aPtr, bPtr) =>
+      reg(require("path").join(readString(aPtr), readString(bPtr))),
+    processPlatform: () => reg(process.platform),
+
+    // ── ExtensionContext helpers ───────────────────────────────────
+    extensionAbsolutePath: (ctxHandle, relPtr) => {
+      const ctx = get(ctxHandle);
+      return reg(ctx ? ctx.asAbsolutePath(readString(relPtr)) : "");
+    },
   };
 
   const VscodeLanguageClient = {