Commit d39e9b1
ci: drop continue-on-error on test-run step (bisect_ppx) (#409)
## Summary
The "Run tests with bisect_ppx instrumentation" step in
`.github/workflows/ci.yml` carried `continue-on-error: true`. Result:
test failures (including QTT typechecker test regressions) were being
reported as CI passes.
## What changes
Removes one line: `continue-on-error: true` from the test-run step at
line 178.
## What is NOT changed
Intentional soft-fail patterns preserved on non-test steps:
- `Lint with odoc` (line 105) — docs lint.
- `Build bench targets` + `Run benches` (lines 127, 131) — benchmarks.
- `Generate HTML coverage report` (line 183) — coverage tooling artefact
(failure here shouldn't mask test results).
## Pattern context
Same anti-pattern class as:
- echo-types' N5Falsifier xfail gate (resolved via echo-types#136).
- echidna's Tier-2/3 live-test soft-fail (resolved via echidna#118).
The principle: "CI green" must reliably mean "tests pass". Soft-failing
test steps breaks that invariant.
## Refs
Estate prover-CI hygiene audit, recorded at:
\`standards/adoption-readiness-grades/AUDIT-FINDINGS-2026-05-28.adoc\`.
## Test plan
- [ ] CI runs on this PR (hard-fails on real test regressions instead of
silently masking).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 03c926e commit d39e9b1
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
179 | 178 | | |
180 | 179 | | |
181 | 180 | | |
| |||
0 commit comments