ci: fix Scorecard enforcer (publish/run-step split + JSON gate) + housekeeping#63
Merged
Merged
Conversation
…rack, SPDX, license badge Reconcile docs to the axiom-free reality. substTop_preserves_typing is a proved theorem (proofs/BetLang.lean:918), verified by `lake build`; zero `axiom` declarations remain. Six artefacts still called it a live axiom: - docs/proof-debt.adoc: move substTop from §(c) NECESSARY AXIOM to §(a) DISCHARGED; marker count 1 -> 0. - PROOF-STATUS.md: TP-4 -> Done; axiom-free note; banned-patterns wording. - PROOF-NEEDS.md: TP-4 status -> done. - .machine_readable/6a2/STATE.a2ml: M4 done; axioms=[]; remaining 10->9; drop already-merged-PR (#53/#54/#55) next-actions. - README.md / README.adoc / EXPLAINME.adoc: "one permitted axiom" -> axiom-free. Untrack build rot + tidy: - remove 8 stale *.bak.20250719-182140 backups. - untrack 321 Gleam build artefacts under lsp/bet-lsp/build/ (already gitignored). - remove broken root symlink SPEC.core.scm (target migrated .scm -> .a2ml). - gitignore lake-manifest.json (zero-dep project; regenerated on every build). Conformance: - add SPDX headers to core/betlang.rkt, lib/ternary.rkt, repl/shell.rkt, tests/basics.rkt (Mustfile requires SPDX on .rkt). - drop redundant/incorrect PMPL-1.0 license badge (LICENSE + SPDX = MPL-2.0). Verified: `lake build` green (Lean v4.15.0), tools/proof-scan.sh clean, working tree clean. No Lean sources changed. https://claude.ai/code/session_01VwbFNQJw23tW8tqM7utWku
…re gate)
The scorecard job invoked ossf/scorecard-action with publish_results: true
AND contained a run: step in the same job. The OSSF attestation flow rejects
that with HTTP 400 ("scorecard job must only have steps with `uses`"), which
fails the whole workflow.
Fix: split into an uses-only publish job plus an unprivileged score-gate job.
The gate reads the aggregate score from JSON output (top-level `.score`); the
previous SARIF path .runs[0].tool.driver.properties.score is absent in SARIF,
so the old gate always read 0 via the `// 0` fallback and failed the < 5 check
(verified live on nextgen-languages scorecard-enforcer run 27468148000).
Repo-specific hygiene folded in while converging onto the canonical enforcer:
tightened top-level read-all to contents:read, bumped upload-sarif v3 -> v4,
and corrected the actions/checkout pin comment (the pinned SHA is v6.0.2, was
mislabelled # v4).
https://claude.ai/code/session_01VwbFNQJw23tW8tqM7utWku
hyperpolymath
marked this pull request as ready for review
June 15, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch carries two commits.
1.
ci:fix OpenSSF Scorecard enforcerscorecardjob ranossf/scorecard-actionwithpublish_results: trueand arun:step in the same job; OSSF rejects that with HTTP 400 ("scorecard job must only have steps withuses")..runs[0].tool.driver.properties.score, which SARIF does not carry → it always read0and failed the< 5check (verified live onnextgen-languagesrun 27468148000).Fix: split into an uses-only publish job + an unprivileged
score-gatejob that re-derives the score in JSON mode (top-level.score). Repo hygiene folded in while converging onto the canonical enforcer: tightened top-levelread-all→contents: read, bumpedupload-sarifv3 → v4, and corrected theactions/checkoutpin comment (the pinned SHA is v6.0.2, was mislabelled# v4).2.
chore:housekeeping (already on this branch)Axiom-free doc reconciliation —
substTop_preserves_typingis a proved theorem (proofs/BetLang.lean:918, verified bylake build); zeroaxiomdeclarations remain. Six docs that still called it a live axiom updated (proof-debt.adoc, PROOF-STATUS.md, PROOF-NEEDS.md, STATE.a2ml, README.md/.adoc, EXPLAINME.adoc). Plus rot cleanup: untracked 321 gitignored Gleam build artefacts + 8 stale.bakfiles, removed a brokenSPEC.core.scmsymlink, added SPDX headers to the four.rktsources, and dropped a redundant PMPL-1.0 license badge.Verification
scorecard-enforcer.ymlvalidated as parseable YAML;lake buildgreen for the housekeeping commit. Scorecard triggers on push-to-main(notpull_request); green lands after merge.https://claude.ai/code/session_01VwbFNQJw23tW8tqM7utWku
Generated by Claude Code