Skip to content

fix(cicd-squabbler-mcp): review follow-ups — copyright line, diagnose shape tolerance#81

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/cicd-squabbler-architecture-kjl1kr
Jul 10, 2026
Merged

fix(cicd-squabbler-mcp): review follow-ups — copyright line, diagnose shape tolerance#81
hyperpolymath merged 1 commit into
mainfrom
claude/cicd-squabbler-architecture-kjl1kr

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Two confirmed findings from the multi-angle review of the Push #2 change set, applied to the just-merged cicd-squabbler-mcp cartridge (#80): the README gains the estate copyright line (every merged sibling ci-cd README carries it on line 2 — SPDX alone lacks attribution), and squabble_diagnose now accepts both the documented bare {checks} shape and the {gate:{checks}} wrapper callers generalise from squabble_fight by analogy (previously an opaque 400; the squabble-app backend tolerates both as of cicd-squabbler#14). One cartridge, one PR.

Schema-validation note

  • This PR adds or modifies one or more cartridge.json manifests.
  • This PR does not touch any cartridge.json.

(README.adoc + mod.js only; the manifest is untouched, so the strict gate's baseline is unaffected. schemas/PINNED-SHA untouched.)

Refs


Generated by Claude Code

… shape tolerance

Two confirmed findings from the multi-angle review of the Push #2 change set,
applied to the just-merged cartridge (#80):

- README.adoc gains the estate copyright line (conventions: every merged
  sibling ci-cd README carries it on line 2; SPDX alone lacks attribution).
- squabble_diagnose accepts both the documented bare shape ({checks}) and
  the gate-wrapped shape ({gate:{checks}}) that callers generalise from
  squabble_fight by analogy — previously an opaque 400; the squabble-app
  backend tolerates both as of cicd-squabbler#14. Error message now names
  both accepted shapes.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SUURnQUnzTXYftzWFs5pfZ
@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 282 issues detected

Severity Count
🔴 Critical 44
🟠 High 131
🟡 Medium 107

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/planner.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/types.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/rollback.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/rollback_test.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/planner_test.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/lsp_client.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/lsp_client_test.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/parser.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/integration_test.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server-cartridges/boj-server-cartridges/cartridges/cross-cutting/orchestration/stack-orchestrator-mcp/adapter/parser_test.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath
hyperpolymath marked this pull request as ready for review July 10, 2026 00:04
@hyperpolymath
hyperpolymath merged commit 6767196 into main Jul 10, 2026
28 of 29 checks passed
@hyperpolymath
hyperpolymath deleted the claude/cicd-squabbler-architecture-kjl1kr branch July 10, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants