Skip to content

fix(bug-filing-mcp): drop unnecessary @ptrCast from the adapter dispatch call (CWE-704) #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Jul 17, 2026
Merged

fix(bug-filing-mcp): drop unnecessary @ptrCast from the adapter dispatch call (CWE-704) #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cartridges/domains/development/bug-filing-mcp/adapter/bug_filing_mcp_adapter.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ fn dispatch(tool: []const u8, args_json: []const u8, out: []u8) Dispatch {
abuf[a.len] = 0;

var len: usize = out.len;
const rc = ffi.boj_cartridge_invoke(@ptrCast(&tnbuf), @ptrCast(&abuf), @ptrCast(out.ptr), &len);
// No @ptrCast needed (CWE-704 fix, matching #89's cartridge_shim.zig
// pattern): [*c] parameters accept array/slice/scalar pointers via
// Zig's own implicit C-pointer coercion.
const rc = ffi.boj_cartridge_invoke(&tnbuf, &abuf, out.ptr, &len);
return switch (rc) {
0 => .{ .status = 200, .body = out[0..len] },
-1 => .{ .status = 404, .body = "{\"error\":\"unknown-tool\"}" },
Expand Down
Loading