fix(ci): unblock E2E + Zig FFI Tests after #150 cartridge.json edits

Two follow-up failures on #150's first CI run, each fixed at source:

1. **Zig FFI Tests** — failed with "no build.zig file found" for
   orchestrator-lsp-mcp. Root cause: the scope step's `git diff
   --name-only -- 'cartridges/**'` pulls a cartridge into the test
   set as soon as ANY file under it changes — including
   cartridge.json. My PR added a `status` field to 15 cartridges'
   cartridge.json, which pulled orchestrator-lsp-mcp into scope, but
   that cart's build.zig lives at `ffi/zig/build.zig` (deeper nesting)
   so the workflow's `cd cartridges/$cart/ffi && zig build test` fell
   over. Tightened the pathspec to `cartridges/*/ffi/**` so only
   ffi/-relevant diffs scope a cart in — matches the workflow's own
   `on.paths` filter, which was already `cartridges/**/ffi/**` (the
   pathspec and the diff filter were inconsistent before).

2. **E2E — Server did not start within 10 seconds** — Elixir backend
   was *found* (the setup-beam fix from the first commit worked), but
   `mix run --no-halt` on a cold runner spends most of the 10s window
   compiling deps. Two changes: (a) added `mix compile` as a workflow
   step so deps land in `_build/` before the test starts the server;
   (b) bumped the script's wait window from 10s (50 × 200ms) to 60s
   (300 × 200ms) so a slow CI cold start doesn't false-fail.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: hyperpolymath

.github/workflows/e2e.yml

@@ -72,6 +72,12 @@ jobs:
         working-directory: elixir
         run: mix deps.get
 
+      - name: Compile Elixir deps
+        # Pre-compile so the in-test `mix run --no-halt` doesn't have
+        # to do it on the critical path of the 60s server-start window.
+        working-directory: elixir
+        run: mix compile
+
       - name: Build FFI libraries
         run: |
           cd ffi/zig && zig build

.github/workflows/zig-test.yml

@@ -52,7 +52,14 @@ jobs:
           all="$(ls -d cartridges/*/ffi/ 2>/dev/null | sed 's|cartridges/||;s|/ffi/||' | sort)"
           if [ "$EVENT" = "pull_request" ]; then
             git fetch --no-tags --depth=50 origin "$BASE_REF" || true
-            changed="$(git diff --name-only "origin/${BASE_REF}...HEAD" -- 'cartridges/**' \
+            # Only scope cartridges whose `ffi/` actually changed —
+            # `cartridge.json` edits (e.g. adding a status field) and
+            # `abi/` edits should not pull a cart into this FFI test
+            # job, which exists to validate Zig builds. Using
+            # `cartridges/*/ffi/**` as the pathspec ensures only
+            # ffi-relevant diffs count (also matches the workflow's
+            # own `on.paths` filter — they were inconsistent before).
+            changed="$(git diff --name-only "origin/${BASE_REF}...HEAD" -- 'cartridges/*/ffi/**' \
                        | awk -F/ '{print $2}' | sort -u)"
             scope=""
             while IFS= read -r cart; do

tests/e2e_full.sh

@@ -131,14 +131,17 @@ bold "Step 1: Starting BoJ server on port $REST_PORT..."
 ( cd "$ELIXIR_DIR" && BOJ_REST_PORT="$REST_PORT" mix run --no-halt ) > "$TMPDIR_TEST/boj-e2e-full.log" 2>&1 &
 PIDS+=($!)
 
-# Wait for health check (up to 10 seconds)
-for i in $(seq 1 50); do
+# Wait for health check (up to 60 seconds — CI cold start can compile
+# Elixir deps on the critical path even when the workflow pre-runs
+# `mix deps.get` / `mix compile`; local runs typically come up in <1s).
+WAIT_ITERS=300
+for i in $(seq 1 $WAIT_ITERS); do
     if curl -sf "$BASE_URL/health" > /dev/null 2>&1; then
         green "  Server is up (waited ~$((i * 200))ms)"
         break
     fi
-    if [[ $i -eq 50 ]]; then
-        red "  ERROR: Server did not start within 10 seconds"
+    if [[ $i -eq $WAIT_ITERS ]]; then
+        red "  ERROR: Server did not start within $((WAIT_ITERS * 200 / 1000)) seconds"
         red "  Log tail:"
         tail -20 "$TMPDIR_TEST/boj-e2e-full.log" 2>/dev/null || true
         exit 1