Skip to content

fix(ci): repair aspect_tests.sh grep-count bash bug (baseline rot) #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
May 20, 2026
Merged

fix(ci): repair aspect_tests.sh grep-count bash bug (baseline rot) #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66ad7e5
fix(ci): repair aspect_tests.sh grep-count bash bug (baseline rot)
hyperpolymath May 20, 2026
5725b11
Merge branch 'main' into fix/ci-baseline-rot-mechanical
hyperpolymath May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/aspect_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ for zigfile in "$zig_ffi_dir"/*.zig; do
;;
esac

has_export=$(grep -cP '(?:pub )?export fn' "$zigfile" 2>/dev/null || echo "0")
has_mutex=$(grep -c 'Mutex' "$zigfile" 2>/dev/null || echo "0")
has_export=$(grep -cP '(?:pub )?export fn' "$zigfile" 2>/dev/null || true)
has_mutex=$(grep -c 'Mutex' "$zigfile" 2>/dev/null || true)

if [[ "$has_export" -gt 0 && "$has_mutex" -eq 0 ]]; then
fail "$basename_zig has $has_export C-ABI exports but no Mutex"
Expand All @@ -95,8 +95,8 @@ for cart_dir in "$PROJECT_DIR"/cartridges/*/ffi; do
fi

if [[ -n "$ffi_zig" ]]; then
has_export=$(grep -c 'pub export fn' "$ffi_zig" 2>/dev/null || echo "0")
has_mutex=$(grep -c 'Mutex' "$ffi_zig" 2>/dev/null || echo "0")
has_export=$(grep -c 'pub export fn' "$ffi_zig" 2>/dev/null || true)
has_mutex=$(grep -c 'Mutex' "$ffi_zig" 2>/dev/null || true)

if [[ "$has_export" -gt 0 && "$has_mutex" -eq 0 ]]; then
fail "$cart_name FFI: $has_export exports, no Mutex"
Expand Down
Loading