feat(feedback): implement feedback-o-tron invoke dispatch (FFI-backed)

[hyperpolymath]

What

Builds feedback-o-tron for real (the follow-up you green-lit), replacing the "Grade D Alpha" stub in feedback_ffi.zig's boj_cartridge_invoke with a live, state-machine-backed implementation, and switching the e2e cycle to the cartridge's actual declared tools.

Key insight

The stub already dispatched the correct cartridge.json tool names (feedback_register_channel/start_collecting/submit/get_stats) — it just returned {"status":"stub"}. The old e2e cycle invoked tools that never existed (open_channel/summary/export/status/list_channels), which is why it got {}. So the fix is: make the FFI real, and point the test at the real tools.

Changes

• feedback_ffi.zig — boj_cartridge_invoke now backs the 4 manifest tools with the existing fb_* channel state machine:
  • feedback_register_channel → fb_register → {"slot":N,"channel":C,"state":1}
  • feedback_start_collecting → fb_start_collecting → {"slot":N,"collecting":true,"state":2}
  • feedback_submit → fb_submit → {"recorded":true,"slot":N,"feedback_count":K}
  • feedback_get_stats → fb_count/fb_positive_count/… → {"total_feedback":…,"positive":…,…}
  • channel/slot/sentiment are read from the JSON args via a small, std.json-free byte scanner (jsonInt) — sufficient for the flat arg objects and version-stable.
• feedback_ffi.zig test — the in-file invoke test now drives the real register → start → submit ×2 → get_stats cycle and asserts the real shapes (so zig build test covers it in CI).
• tests/e2e_full.sh Step 6 — rewritten to exercise the real tools via the "arguments" object (the field BojRest forwards to the FFI); asserts slot / collecting:true / recorded:true / total_feedback. Removes the FEEDBACK_OTRON skip from fix(rest): restore tiered /menu + make /cartridges & feedback-o-tron E2E truthful #192.
• No Elixir change — the router already forwards arguments and returns the FFI's parsed JSON as the body. The cross-language flow (Zig JSON → Invoker parse → Jason re-encode → test) lands the keys the assertions read.

Verification — please note

e2e_full.sh passes bash -n + shellcheck locally. The Zig could not be compiled locally: this sandbox's network is GitHub-only — ziglang.org returns 403 and Zig isn't on GitHub releases, and apt is blocked. So the FFI is verified by CI (abi-drift.yml + e2e.yml both run zig build) and the added Zig unit test. I'll watch this PR and fix any compile error promptly. (If you'd rather I verify locally, allowing ziglang.org in the environment's network policy would let me install Zig 0.15.1.)

The ABI is unchanged (only the dispatch body), so abi-drift should stay green.

🤖 Draft via Claude Code.

---

Generated by Claude Code

[github-actions]

🏁 path-claims bench

Commit d6e4678

Numbers

path-claims bench  (node v22.22.3)

  scenario                                              iters       ms        ns/op          ops/s
  --------------------------------------------------------------------------------------------------------------
  register: 10 active claims, 3 new paths               50000 iters    138 ms      2.77 µs/op    360.4k ops/s
  register: 100 active claims, 3 new paths              20000 iters    249 ms     12.49 µs/op     80.1k ops/s
  register: 1000 active claims, 3 new paths              5000 iters    769 ms    153.95 µs/op      6.5k ops/s
  register: 100 active claims, 20 new paths              5000 iters    276 ms     55.33 µs/op     18.1k ops/s

  pathsOverlap: deep diverge at segment 4             1000000 iters    122 ms     122.8 ns/op     8.14M ops/s
  pathsOverlap: short prefix match                    1000000 iters    105 ms     105.9 ns/op     9.45M ops/s

  refresh (existing claim)                             100000 iters      8 ms      81.3 ns/op    12.30M ops/s
  list (100 active claims)                              50000 iters    226 ms      4.54 µs/op    220.3k ops/s

  (Bench numbers depend on host; use deltas across commits, not absolute values.)

Host-dependent — compare deltas across commits, not absolute values.

[github-actions]

🔍 Hypatia Security Scan

Findings: 279 issues detected

Severity	Count
🔴 Critical	15
🟠 High	131
🟡 Medium	133

⚠️ Action Required: Critical security issues found!

View findings

[
  {
    "reason": "Stale AI session file -- delete",
    "type": "stale",
    "file": "GEMINI.md",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "medium"
  },
  {
    "reason": "Action    if: always()\n        uses: actions/upload-artifact@ea165 needs attention",
    "type": "unpinned_action",
    "file": "e2e.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action perpolymath/standards/.github/workflows/governance-reusable.yml@main\n needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in abi-drift.yml",
    "type": "missing_timeout_minutes",
    "file": "abi-drift.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "missing_timeout_minutes",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in container-publish.yml",
    "type": "missing_timeout_minutes",
    "file": "container-publish.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence