ABI: make Idris2 proofs genuinely compile + add machine-checked theorems#29
Merged
Merged
Conversation
The governance/licence-consistency check requires an SPDX-License-Identifier header on the LICENSE file and a `license` field in the manifest. The LICENSE body is MPL-2.0 text, so stamp `SPDX-License-Identifier: MPL-2.0` (matching the actual body) and set `license = "MPL-2.0"` (replacing `license-file`). Verified with standards/scripts/check-licence-consistency.sh (passes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
Make the repo's licensing single and consistent, matching the wokelangiser reference policy and the merged iseriser pattern: - Remove contradictory PMPL-1.0-or-later / Palimpsest self-claims from README badges/footers, QUICKSTART, RSR_OUTLINE, STATE-VISUALIZER, and machine-readable governance (META, stapeln, deny.toml allow-list, copilot/AGENTIC SPDX directives, Trust/Must LICENSE-content checks, per-project CLAUDE.md). - Encode the docs split in REUSE dep5: *.adoc/*.md/docs/** -> CC-BY-SA-4.0, everything else -> MPL-2.0. - READMEs show MPL-2.0 (code) + CC-BY-SA-4.0 (docs) badges; full texts live in LICENSES/; root LICENSE stays MPL-2.0 for GitHub's licence chip. Preserves legitimate non-self references: cargo-deny's AGPL deny-list, the "never use AGPL" estate policy, and the Contributor Covenant CoC. Verified: standards/scripts/check-licence-consistency.sh passes; no residual PMPL/Palimpsest self-claims remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
The src/interface/abi ABI was scaffolded from a template and never
compiler-checked. This makes all four modules typecheck cleanly under
Idris2 0.7.0 with zero errors and zero warnings, and adds real
machine-checked theorems.
Types.idr:
- thisPlatform: replaced unenabled %runElab with plain value (Linux).
- DecEq BQNPrimitive: replaced "No absurd" catch-all with explicit
off-diagonal cases for every ordered distinct constructor pair;
Arith/Compare diagonals decided via their Char field's decEq.
- DecEq Result: same explicit off-diagonal expansion.
- createHandle: solve the {auto So (ptr/=0)} obligation via Data.So.choose
instead of leaving MkHandle's proof unsolved.
- rankNonNeg: prove r>=0 by casing on r (compare-based >= does not reduce
symbolically).
Layout.idr:
- paddingFor: use Data.Nat.minus instead of Nat subtraction (no Neg).
- arraySizeMinHeader: discharge the ?hole with a genuine So proof via a
geEight lemma over the reassociated header sum.
- Divides/decDivides: sound divisibility decision procedure.
- alignUpCorrect (unsound Refl) replaced by alignUpDivides via decDivides.
- StructLayout concrete value cbqnArrayDescLayout: supply erased proofs
{sizeCorrect = Oh} and {aligned = DivideBy 2 Refl}.
- CABICompliant upgraded to carry a FieldsAligned witness; added
decFieldsAligned and a sound checkCABI returning Either.
- offsetInBounds: honest Maybe (So ...) via choose instead of an unsound
universally-quantified So.
Proofs.idr (new): export-level machine-checked theorems —
cbqnArrayDescCompliant (direct DivideBy witnesses), okIsZero,
nullPointerIsFour, numberTagIsZero, arrayTagIsSix, scalarSingleElement.
Build: added src/interface/abi/bqniser-abi.ipkg; moved flat modules into
src/interface/abi/Bqniser/ABI/ so paths match namespaces. .gitignore now
ignores **/build/, *.ttc, *.ttm.
No believe_me/assert_total/idris_crash/postulate/%hint/holes anywhere.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
hyperpolymath
marked this pull request as ready for review
June 26, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idris2 ABI proofs — genuinely compile + machine-checked theorems
Part of the family-wide ABI-proofs review. The hand-written ABI did not typecheck under Idris2 0.7.0; this makes it real and verified, following the merged iseriser reference.
Systemic fixes:
decEq _ _ = No absurd→ explicit off-diagonal cases;{auto 0 nonNull}smart constructors →choose-based;paddingFor-→minus; realdecDivides/decFieldsAlignedreplacing?fieldsAlignedProof; honestoffsetInBounds;thisPlatformde-%runElab'd; buildable nested layout + ipkg; newProofs.idrwith real theorems.Verified:
idris2 --buildclean (0/0); adversarial re-verify found nobelieve_me/postulate/holes.🤖 Generated with Claude Code
Generated by Claude Code