Skip to content

Commit a701338

Browse files
ci(antipattern): broaden TS allowlist (cli, mod.ts, lsp-server, *vscode*, deno-*) (#23)
Follow-up to the first allowlist patch — adds: - `/cli/` (CLI entry points) - `mod.ts` (canonical Deno module entrypoint) - `lsp-server.ts`, `*-lsp.ts` (LSP servers) - broader `*vscode*` (was `/vscode/` only — now covers `vscode-extension/`, `extensions/vscode/`, etc.) - `/deno-*/` (subprojects explicitly named for Deno) Estate-wide re-survey showed these patterns dominate the false-positive set.
1 parent 7473b4d commit a701338

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

.github/workflows/rsr-antipattern.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,16 @@ jobs:
2828
- name: Check for TypeScript
2929
run: |
3030
# Allowlist (TS legitimate as a bridge/adapter to a non-ReScript ecosystem):
31-
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI to ReScript core)
32-
# *.d.ts - TypeScript type declarations for ReScript FFI
33-
# tests/, test/ - Deno test runners verifying ReScript output
34-
# scripts/ - Deno build scripts (bundle, dev-server, etc.)
35-
# mcp-adapter/ - MCP server adapters (MCP protocol is Deno/TS-typed by spec)
36-
# vscode/ - VSCode extensions (TS is the ecosystem default)
31+
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI)
32+
# *.d.ts - TypeScript type declarations for ReScript FFI
33+
# tests/, test/ - Deno test runners
34+
# scripts/ - Deno build scripts
35+
# mcp-adapter/ - MCP server adapters (MCP is Deno/TS-typed by spec)
36+
# *vscode* - VSCode extensions (TS is the ecosystem default)
37+
# cli/ - CLI entry points (Deno scripts)
38+
# mod.ts - canonical Deno module entrypoint
39+
# *lsp-server.ts, *lsp.ts - Language Server Protocol implementations
40+
# deno-*/ - subprojects explicitly named for Deno
3741
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) \
3842
| grep -v node_modules \
3943
| grep -v '/bindings/' \
@@ -42,7 +46,12 @@ jobs:
4246
| grep -v '/test/' \
4347
| grep -v '/scripts/' \
4448
| grep -v '/mcp-adapter/' \
45-
| grep -v '/vscode/' \
49+
| grep -Ev '/[^/]*vscode[^/]*/' \
50+
| grep -v '/cli/' \
51+
| grep -v '/mod\.ts$' \
52+
| grep -Ev 'lsp[-_]?server\.ts$' \
53+
| grep -Ev '[/-]lsp\.ts$' \
54+
| grep -Ev '/deno-[^/]+/' \
4655
|| true)
4756
if [ -n "$TS_FILES" ]; then
4857
echo "❌ TypeScript files detected - use ReScript instead"

0 commit comments

Comments
 (0)