Skip to content

Commit c59cb98

Browse files
ci(antipattern): broaden TS allowlist (cli, mod.ts, lsp-server, *vscode*, deno-*) (#35)
Follow-up to the first allowlist patch — adds: - `/cli/` (CLI entry points) - `mod.ts` (canonical Deno module entrypoint) - `lsp-server.ts`, `*-lsp.ts` (LSP servers) - broader `*vscode*` (was `/vscode/` only — now covers `vscode-extension/`, `extensions/vscode/`, etc.) - `/deno-*/` (subprojects explicitly named for Deno) Estate-wide re-survey showed these patterns dominate the false-positive set.
1 parent af52317 commit c59cb98

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

.github/workflows/rsr-antipattern.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,16 @@ jobs:
3434
- name: Check for TypeScript
3535
run: |
3636
# Allowlist (TS legitimate as a bridge/adapter to a non-ReScript ecosystem):
37-
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI to ReScript core)
38-
# *.d.ts - TypeScript type declarations for ReScript FFI
39-
# tests/, test/ - Deno test runners verifying ReScript output
40-
# scripts/ - Deno build scripts (bundle, dev-server, etc.)
41-
# mcp-adapter/ - MCP server adapters (MCP protocol is Deno/TS-typed by spec)
42-
# vscode/ - VSCode extensions (TS is the ecosystem default)
37+
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI)
38+
# *.d.ts - TypeScript type declarations for ReScript FFI
39+
# tests/, test/ - Deno test runners
40+
# scripts/ - Deno build scripts
41+
# mcp-adapter/ - MCP server adapters (MCP is Deno/TS-typed by spec)
42+
# *vscode* - VSCode extensions (TS is the ecosystem default)
43+
# cli/ - CLI entry points (Deno scripts)
44+
# mod.ts - canonical Deno module entrypoint
45+
# *lsp-server.ts, *lsp.ts - Language Server Protocol implementations
46+
# deno-*/ - subprojects explicitly named for Deno
4347
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) \
4448
| grep -v node_modules \
4549
| grep -v '/bindings/' \
@@ -48,7 +52,12 @@ jobs:
4852
| grep -v '/test/' \
4953
| grep -v '/scripts/' \
5054
| grep -v '/mcp-adapter/' \
51-
| grep -v '/vscode/' \
55+
| grep -Ev '/[^/]*vscode[^/]*/' \
56+
| grep -v '/cli/' \
57+
| grep -v '/mod\.ts$' \
58+
| grep -Ev 'lsp[-_]?server\.ts$' \
59+
| grep -Ev '[/-]lsp\.ts$' \
60+
| grep -Ev '/deno-[^/]+/' \
5261
|| true)
5362
if [ -n "$TS_FILES" ]; then
5463
echo "❌ TypeScript files detected - use ReScript instead"

0 commit comments

Comments
 (0)