fix(conative-gating): sweep .expect("TODO: handle error") — 76 sites cleared

Replaced all 76 occurrences of `.expect("TODO: handle error")` with context-appropriate patterns:

- 7 in slm/src/lib.rs (test code) → `.unwrap()`
- 9 in src/main.rs (JSON serialization) → `.expect("invariant: JSON serialization of struct cannot fail")`
- 25 in src/oracle/src/lib.rs (test code) → `.unwrap()`
- 35 in src/contract/src/lib.rs (test code) → `.unwrap()`

Tests: 49 passed / 0 failed

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: hyperpolymath

src/contract/src/lib.rs

@@ -1539,7 +1539,7 @@ mod tests {
             "fn main() { println!(\"Hello\"); }",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
         assert!(decision.refusal.is_none());
     }
@@ -1552,11 +1552,11 @@ mod tests {
             "export const foo: string = 'bar';",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Block);
         assert!(decision.refusal.is_some());
 
-        let refusal = decision.refusal.expect("TODO: handle error");
+        let refusal = decision.refusal.unwrap();
         assert_eq!(refusal.category, RefusalCategory::ForbiddenLanguage);
         assert_eq!(refusal.code, RefusalCode::Lang100TypeScript);
     }
@@ -1569,10 +1569,10 @@ mod tests {
             r#"let password = "supersecret123456""#,
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Block);
 
-        let refusal = decision.refusal.expect("TODO: handle error");
+        let refusal = decision.refusal.unwrap();
         assert_eq!(refusal.category, RefusalCategory::ForbiddenPattern);
     }
 
@@ -1581,7 +1581,7 @@ mod tests {
         let runner = ContractRunner::new();
         let request = GatingRequest::new(create_proposal("src/lib.rs", "pub fn hello() {}"));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         let audit = runner.audit(&request, &decision);
 
         assert_eq!(audit.request_id, request.request_id);
@@ -1638,7 +1638,7 @@ mod tests {
             "import os\ndef configure(): pass",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 
@@ -1650,8 +1650,8 @@ mod tests {
         let request1 = GatingRequest::new(create_proposal("a.rs", "fn main() {}"));
         let request2 = GatingRequest::new(create_proposal("b.rs", "fn main() {}"));
 
-        let decision1 = runner.evaluate(&request1).expect("TODO: handle error");
-        let decision2 = runner.evaluate(&request2).expect("TODO: handle error");
+        let decision1 = runner.evaluate(&request1).unwrap();
+        let decision2 = runner.evaluate(&request2).unwrap();
 
         assert_ne!(decision1.decision_id, decision2.decision_id);
         assert_ne!(decision1.request_id, decision2.request_id);
@@ -1693,7 +1693,7 @@ mod tests {
     fn test_contract_runner_default() {
         let runner = ContractRunner::default();
         let request = GatingRequest::new(create_proposal("lib.rs", "pub fn foo() {}"));
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 
@@ -1721,10 +1721,10 @@ mod tests {
             "const x: string = 'hello';",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert!(decision.refusal.is_some());
 
-        let refusal = decision.refusal.expect("TODO: handle error");
+        let refusal = decision.refusal.unwrap();
         assert!(!refusal.evidence.is_empty());
         assert_eq!(refusal.evidence[0].evidence_type, EvidenceType::ContentMarker);
     }
@@ -1737,10 +1737,10 @@ mod tests {
             "import os",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
-        let refusal = decision.refusal.expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
+        let refusal = decision.refusal.unwrap();
         assert!(refusal.remediation.is_some());
-        assert!(refusal.remediation.expect("TODO: handle error").contains("only allowed in salt"));
+        assert!(refusal.remediation.unwrap().contains("only allowed in salt"));
     }
 
     #[test]
@@ -1751,19 +1751,19 @@ mod tests {
             "package main\nfunc main() {}",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
-        let refusal = decision.refusal.expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
+        let refusal = decision.refusal.unwrap();
         assert_eq!(refusal.code, RefusalCode::Lang102Go);
         assert!(refusal.remediation.is_some());
-        assert!(refusal.remediation.expect("TODO: handle error").contains("Rust"));
+        assert!(refusal.remediation.unwrap().contains("Rust"));
     }
 
     #[test]
     fn test_contract_evaluator_records_oracle_stage() {
         let runner = ContractRunner::new();
         let request = GatingRequest::new(create_proposal("lib.rs", "pub fn foo() {}"));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert!(decision.processing.stages_executed.contains(&"oracle".to_string()));
         assert!(decision.evaluations.oracle.is_some());
     }
@@ -1773,7 +1773,7 @@ mod tests {
         let runner = ContractRunner::new();
         let request = GatingRequest::new(create_proposal("lib.rs", "pub fn foo() {}"));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert!(decision.processing.duration_us > 0);
     }
 
@@ -1795,20 +1795,20 @@ mod tests {
     fn test_audit_entry_json_serialization() {
         let runner = ContractRunner::new();
         let request = GatingRequest::new(create_proposal("lib.rs", "pub fn foo() {}"));
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         let audit = runner.audit(&request, &decision);
 
         let json = audit.to_json();
         assert!(json.is_ok());
-        let json_str = json.expect("TODO: handle error");
+        let json_str = json.unwrap();
         assert!(json_str.contains("\"verdict\""));
     }
 
     #[test]
     fn test_audit_entry_compact_json() {
         let runner = ContractRunner::new();
         let request = GatingRequest::new(create_proposal("lib.rs", "pub fn foo() {}"));
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         let audit = runner.audit(&request, &decision);
 
         let json = audit.to_json_compact();
@@ -1819,7 +1819,7 @@ mod tests {
     fn test_audit_entry_pretty_json() {
         let runner = ContractRunner::new();
         let request = GatingRequest::new(create_proposal("lib.rs", "pub fn foo() {}"));
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         let audit = runner.audit(&request, &decision);
 
         let json = audit.to_json_pretty();
@@ -1948,7 +1948,7 @@ mod tests {
         let json = baseline.to_json();
         assert!(json.is_ok());
 
-        let json_str = json.expect("TODO: handle error");
+        let json_str = json.unwrap();
         let parsed = RegressionBaseline::from_json(&json_str);
         assert!(parsed.is_ok());
     }
@@ -1980,7 +1980,7 @@ mod tests {
             "defmodule MyModule, do: :ok",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         // Should be allowed as tier1 language
         assert!(matches!(decision.verdict, Verdict::Allow),
             "Elixir should be allowed, got {:?}", decision.verdict);
@@ -1994,7 +1994,7 @@ mod tests {
             "const std = @import(\"std\");\npub fn main() void {}",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 
@@ -2006,7 +2006,7 @@ mod tests {
             "@react.component\nlet make = () => React.string(\"Hello\")",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 
@@ -2018,7 +2018,7 @@ mod tests {
             "procedure Main is\nbegin\n  null;\nend Main;",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 
@@ -2030,7 +2030,7 @@ mod tests {
             "module Main where\nmain = putStrLn \"Hello\"",
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 
@@ -2042,9 +2042,9 @@ mod tests {
             r#"{"name": "test", "version": "1.0.0"}"#,
         ));
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Block);
-        let refusal = decision.refusal.expect("TODO: handle error");
+        let refusal = decision.refusal.unwrap();
         assert_eq!(refusal.code, RefusalCode::Tool200NpmWithoutDeno);
     }
 
@@ -2057,7 +2057,7 @@ mod tests {
         ));
         request.proposal.files_affected.push("deno.json".to_string());
 
-        let decision = runner.evaluate(&request).expect("TODO: handle error");
+        let decision = runner.evaluate(&request).unwrap();
         assert_eq!(decision.verdict, Verdict::Allow);
     }
 

src/main.rs

@@ -563,7 +563,7 @@ fn scan_directory(
         Ok(result) => {
             match format {
                 OutputFormat::Json => {
-                    println!("{}", serde_json::to_string_pretty(&result).expect("TODO: handle error"));
+                    println!("{}", serde_json::to_string_pretty(&result).expect("invariant: JSON serialization of struct cannot fail"));
                 }
                 OutputFormat::Compact => {
                     let status = if !result.violations.is_empty() {
@@ -675,7 +675,7 @@ fn check_content(
         Ok(result) => {
             match format {
                 OutputFormat::Json => {
-                    println!("{}", serde_json::to_string_pretty(&result).expect("TODO: handle error"));
+                    println!("{}", serde_json::to_string_pretty(&result).expect("invariant: JSON serialization of struct cannot fail"));
                 }
                 OutputFormat::Compact => {
                     let status = if !result.violations.is_empty() {
@@ -741,7 +741,7 @@ fn show_policy(format: &OutputFormat, section: Option<&str>) {
 
     match format {
         OutputFormat::Json => {
-            println!("{}", serde_json::to_string_pretty(&policy).expect("TODO: handle error"));
+            println!("{}", serde_json::to_string_pretty(&policy).expect("invariant: JSON serialization of struct cannot fail"));
         }
         OutputFormat::Compact => {
             println!(
@@ -825,7 +825,7 @@ fn validate_proposal(
         Ok(result) => {
             match format {
                 OutputFormat::Json | OutputFormat::Compact => {
-                    println!("{}", serde_json::to_string_pretty(&result).expect("TODO: handle error"));
+                    println!("{}", serde_json::to_string_pretty(&result).expect("invariant: JSON serialization of struct cannot fail"));
                 }
                 OutputFormat::Text => {
                     println!("Proposal: {}", result.proposal_id);
@@ -989,7 +989,7 @@ fn run_contract_tests(
 
     match format {
         OutputFormat::Json => {
-            println!("{}", serde_json::to_string_pretty(&summary).expect("TODO: handle error"));
+            println!("{}", serde_json::to_string_pretty(&summary).expect("invariant: JSON serialization of struct cannot fail"));
         }
         OutputFormat::Compact => {
             println!(
@@ -1186,10 +1186,10 @@ fn eval_contract_request(request_path: &Path, format: &OutputFormat, include_aud
                         decision: decision.clone(),
                         audit
                     })
-                    .expect("TODO: handle error")
+                    .expect("invariant: JSON serialization of struct cannot fail")
                 );
             } else {
-                println!("{}", serde_json::to_string_pretty(&decision).expect("TODO: handle error"));
+                println!("{}", serde_json::to_string_pretty(&decision).expect("invariant: JSON serialization of struct cannot fail"));
             }
         }
         OutputFormat::Compact => {
@@ -1223,7 +1223,7 @@ fn eval_contract_request(request_path: &Path, format: &OutputFormat, include_aud
             if include_audit {
                 let audit = runner.audit(&request, &decision);
                 println!("\nAudit Log Entry:");
-                println!("{}", serde_json::to_string_pretty(&audit).expect("TODO: handle error"));
+                println!("{}", serde_json::to_string_pretty(&audit).expect("invariant: JSON serialization of struct cannot fail"));
             }
         }
     }
@@ -1324,7 +1324,7 @@ fn show_contract_schema(format: &OutputFormat, section: Option<&str>) {
                 ],
             };
 
-            println!("{}", serde_json::to_string_pretty(&schema).expect("TODO: handle error"));
+            println!("{}", serde_json::to_string_pretty(&schema).expect("invariant: JSON serialization of struct cannot fail"));
         }
         OutputFormat::Compact | OutputFormat::Text => {
             let show_all = section.is_none();
@@ -1515,7 +1515,7 @@ fn run_redteam_tests(
 
     match format {
         OutputFormat::Json => {
-            println!("{}", serde_json::to_string_pretty(&summary).expect("TODO: handle error"));
+            println!("{}", serde_json::to_string_pretty(&summary).expect("invariant: JSON serialization of struct cannot fail"));
         }
         OutputFormat::Compact => {
             println!(
@@ -1767,7 +1767,7 @@ fn run_regression_tests(
 
     match format {
         OutputFormat::Json => {
-            println!("{}", serde_json::to_string_pretty(&report).expect("TODO: handle error"));
+            println!("{}", serde_json::to_string_pretty(&report).expect("invariant: JSON serialization of struct cannot fail"));
         }
         OutputFormat::Compact => {
             println!(