Skip to content

chore: remove obsolete/corrupted check-no-vlang.sh gate - #20

Merged
hyperpolymath merged 4 commits into
mainfrom
chore/remove-obsolete-vlang-check
Jul 27, 2026
Merged

chore: remove obsolete/corrupted check-no-vlang.sh gate#20
hyperpolymath merged 4 commits into
mainfrom
chore/remove-obsolete-vlang-check

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Removes the estate's scripts/check-no-vlang.sh gate and the CI step that
invoked it.

Why

V (vlang.io) was banned from the estate years ago. check-no-vlang.sh was
written to enforce that ban. At some point a global search-and-replace ran
"V" -> "zig" across the file and it now bans Zig instead -- Zig is the
estate's primary systems/FFI language (Zig-first ABI/FFI doctrine), so this
script has been silently failing CI for any repo that legitimately touches
Zig, and is worthless as a V-lang check now that "V" no longer appears in it.

Evidence of the corruption (from the script's own comments before removal):

  • check-no-vlang.sh — enforce "ziguage is banned in the estate". (i.e. "V
    language" got replaced with "ziguage")
  • Estate rule: zig (vlang.io) is banned. (vlang.io is V's site, not Zig's)
  • PATTERNS=( ... 'zig' 'zig' 'vlang' ... ) (a duplicated replacement)
  • failure message: zig has been replaced by zig-unified-api-adapter.

V is long retired from the estate and this check is obsolete either way, so
rather than fix the corrupted pattern list, this PR deletes the script and
its CI step outright.

What changed

  • git rm scripts/check-no-vlang.sh
  • Removed the "No zig references" / "No V-lang references" step from the
    CI workflow that invoked it (job/workflow otherwise untouched).

No other files were modified.

🤖 Generated with Claude Code

hyperpolymath and others added 2 commits July 27, 2026 18:38
V (vlang.io) was banned from the estate long ago and check-no-vlang.sh
enforced that. A prior global search-and-replace rewrote "V" -> "zig"
throughout the script, so it now bans Zig -- the estate's primary
systems/FFI language -- instead of V. Delete the script and the CI step
that invoked it; V is long gone either way so there is nothing left to
enforce.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath marked this pull request as ready for review July 27, 2026 18:30
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 18:31
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 18:52
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 19:03
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 19:58
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 6a2adcc into main Jul 27, 2026
39 of 40 checks passed
@hyperpolymath
hyperpolymath deleted the chore/remove-obsolete-vlang-check branch July 27, 2026 21:01
@gitar-bot

gitar-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

Running post-merge workflows

CI failed: 1 test failure due to a markdown file in docs/ violating AsciiDoc policy, and 1 build failure from unallowlisted repository root entries.

Overview

Two separate CI checks failed: one enforcing the documentation format (AsciiDoc required under docs/) and another checking repository root shape allowlists. Total logs analyzed: 2.

Failures

Documentation Format Check Failed (confidence: high)

  • Type: test
  • Affected jobs: 90107048488
  • Related to change: no
  • Root cause: Found .md file docs/tech-debt-2026-05-26.md in docs/ which violates the repository policy requiring .adoc files unless explicitly allowlisted.
  • Suggested fix: Convert docs/tech-debt-2026-05-26.md to .adoc, or add a justified entry to the ALLOWED list in scripts/check-no-md-in-docs.sh.

Root Shape Check Failed (confidence: high)

  • Type: build
  • Affected jobs: 90106896326
  • Related to change: yes
  • Root cause: Files and directories such as ARCHITECTURE.md, CODE_OF_CONDUCT.md, Containerfile, GOVERNANCE.md, LICENSES/, MAINTAINERS, and mise.toml exist in the repository root but are not present in the allowlist.
  • Suggested fix: Add the unapproved root entries to .machine_readable/root-allow.txt with justified entries or move them into appropriate subdirectories.

Summary

  • Change-related failures: 1 (Root shape check failure due to unallowlisted files in the repository root)
  • Infrastructure/flaky failures: 0
  • Recommended action: Address the root shape allowlist and convert or allowlist the newly added markdown file in docs/.
Code Review ✅ Approved

Removes the obsolete check-no-vlang.sh script and its corresponding CI step, resolving the corrupted validation gate that incorrectly banned Zig. No issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant