Commit 66701ff
committed
fix(ci): version_check via env var — unblocks acl2/hol4 cron cells (#75)
Both Smoke-check and Stub-sentinel-detection steps in container-ci.yml
template `matrix.version_check` directly inside outer single quotes:
-c '${{ matrix.version_check }}'
For acl2 (`echo '(acl2::quit)' | acl2 …`) and hol4 (`echo '(* quit *);'
| hol …`), the embedded `'` closes the outer string and bash fails
parsing with `syntax error near unexpected token '('`. The cell exits 2
before the inner shell ever runs — `|| true` cannot rescue it because
the outer parse fails first.
Confirmed root cause of the persistent acl2 + hol4 reds in the weekly
Container Build Verification cron since a87fae1 (2026-04-27); same
defect was inherited by #157 when it added the Stub-sentinel step on
2026-05-31. Six consecutive cron runs show the same two cells red.
Fix: pass `version_check` through a job-step `env:` block as
`VERSION_CHECK` and dereference with `-c "$VERSION_CHECK"`. The outer
shell now sees a clean double-quoted variable expansion; the inner
`/bin/sh -c` receives the literal command with its single quotes intact.
The same shape applied to both steps so the fix is uniform.
Side benefit: defends both steps against any future `version_check`
matrix entry containing single quotes, parens, or other shell
metacharacters. Caveat documented inline: matrix values must not embed
literal `$`-prefixed shell variables that would expand at the runner
level.
Closes the longest-standing wave3 container-cron red and lets #157's
stub-sentinel detection function across all 8 matrix cells instead of 6.
Refs #75, refs #157.1 parent 78a65dc commit 66701ff
1 file changed
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
177 | 183 | | |
| 184 | + | |
| 185 | + | |
178 | 186 | | |
179 | 187 | | |
180 | | - | |
| 188 | + | |
181 | 189 | | |
182 | 190 | | |
183 | 191 | | |
| |||
188 | 196 | | |
189 | 197 | | |
190 | 198 | | |
| 199 | + | |
| 200 | + | |
191 | 201 | | |
192 | 202 | | |
193 | 203 | | |
194 | | - | |
| 204 | + | |
195 | 205 | | |
196 | 206 | | |
197 | 207 | | |
| |||
0 commit comments