Skip to content

Commit 876520b

Browse files
hyperpolymathclaude
andcommitted
fix(ci): rust-ci.yml use --features verisim, not --all-features (#85)
--all-features force-enables flint/spark/chapel — deliberately opt-in, system-library-dependent features (libflint LGPL-3, GNAT+libechidna_spark, Zig FFI) that the default GitHub runner cannot link. This made Test Suite / Code Coverage / MVP Smoke / Julia Integration fail on EVERY PR (present on main; surfaced on #73) with: rust-lld: error: unable to find library -lflint build.rs already gates -lflint behind cfg(feature="flint") correctly; the defect was the workflow forcing the feature on. flint/spark/chapel keep their dedicated CI (chapel-ci.yml, SPARK Theatre Gate, live-provers.yml). verisim is the only pure-Rust optional feature → safe maximal set for the bare-runner clippy/test/doc/MSRV steps. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d3db97d commit 876520b

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

.github/workflows/rust-ci.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,20 @@ jobs:
4545
- name: Check formatting
4646
run: cargo fmt --all -- --check
4747

48+
# NOTE: use --features verisim, NOT --all-features. `flint`/`spark`/
49+
# `chapel` are deliberately opt-in, system-library-dependent features
50+
# (libflint LGPL-3 / GNAT+libechidna_spark / Zig FFI lib) that the bare
51+
# runner cannot link. They have dedicated CI (chapel-ci.yml, the SPARK
52+
# Theatre Gate, live-provers.yml). `verisim` is the only pure-Rust
53+
# optional feature, so it is the safe maximal set here. (echidna#85)
4854
- name: Clippy lints
49-
run: cargo clippy --all-targets --all-features -- -D warnings
55+
run: cargo clippy --all-targets --features verisim -- -D warnings
5056

5157
- name: Run unit tests
52-
run: cargo test --lib --all-features
58+
run: cargo test --lib --features verisim
5359

5460
- name: Run integration tests
55-
run: cargo test --test integration_tests --all-features
61+
run: cargo test --test integration_tests --features verisim
5662

5763
- name: Build release
5864
run: cargo build --release
@@ -133,7 +139,7 @@ jobs:
133139
uses: Swatinem/rust-cache@ad397744b0d591a723ab90405b7247fac0e6b8db # v2
134140

135141
- name: Build documentation
136-
run: cargo doc --no-deps --all-features
142+
run: cargo doc --no-deps --features verisim # see echidna#85 (no --all-features on bare runner)
137143
env:
138144
RUSTDOCFLAGS: -D warnings
139145

@@ -202,4 +208,4 @@ jobs:
202208
uses: Swatinem/rust-cache@ad397744b0d591a723ab90405b7247fac0e6b8db # v2
203209

204210
- name: Check MSRV
205-
run: cargo check --all-features
211+
run: cargo check --features verisim # see echidna#85 (no --all-features on bare runner)

0 commit comments

Comments
 (0)