From 4b1548f6e5137ec209032db4962e057dad62207a Mon Sep 17 00:00:00 2001 From: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com> Date: Thu, 28 May 2026 09:31:22 +0100 Subject: [PATCH] ci(live-provers): drop continue-on-error on Tier-2/3 live-test steps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The two "Run live test for ${{ matrix.backend }} (allow-fail while Wave-X wires up)" steps carried `continue-on-error: true`. Comments explicitly disclosed the soft-fail was transitional, but the gate silently masks real prover regressions: a successful Tier-2 / Tier-3 matrix run says "live test PASSED" even when the cargo test step crashed with a real prover error. This is the same anti-pattern class as echo-types' N5Falsifier xfail gate (resolved via PR #136): a self-decaying CI assertion that masks proof-validity once the underlying state matures. Removing both soft-fails so Tier-2/3 results are honest. Provision steps and job-level continue-on-error on best-effort environment setup are preserved — those are intentional resilience for apt-installing 30+ heterogeneous provers, not proof-validity masking. Refs hygiene audit 2026-05-28 (`standards/adoption-readiness-grades/ AUDIT-FINDINGS-2026-05-28.adoc`). Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/live-provers.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/live-provers.yml b/.github/workflows/live-provers.yml index ba2f7324..48d2fa6a 100644 --- a/.github/workflows/live-provers.yml +++ b/.github/workflows/live-provers.yml @@ -276,8 +276,7 @@ jobs: hol-light) true ;; *) "${{ matrix.backend }}" --version 2>/dev/null || true ;; esac - - name: Run live test for ${{ matrix.backend }} (allow-fail while Wave-2 wires up) - continue-on-error: true + - name: Run live test for ${{ matrix.backend }} run: cargo test --test live_prover_suite --features live-provers -- --nocapture ${{ matrix.backend }} # ============================================================================ @@ -399,8 +398,7 @@ jobs: ortools) ortools_solve --help 2>&1 | head -n 1 || true ;; hol4|acl2|scip|imandra) true ;; esac - - name: Run live test for ${{ matrix.backend }} (allow-fail while Wave-3 wires up) - continue-on-error: true + - name: Run live test for ${{ matrix.backend }} run: cargo test --test live_prover_suite --features live-provers -- --nocapture ${{ matrix.backend }} # ============================================================================