ci: vendor validation scripts and remove remote action pins

[hyperpolymath]

Automated PR to fix CI after deleted actions.

[gitar-bot]

Gitar has auto-approved this PR (configure)

[gitar-bot]

Code Review ✅ Approved 2 resolved / 2 findings

Vendors validation scripts and removes remote action pins to fix CI stability. No issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

✅ 2 resolved

✅ Edge Case: while-read loops skip final line lacking trailing newline

📄 .githooks/validate-a2ml.sh:102-111 📄 .githooks/validate-a2ml.sh:128-142 📄 .githooks/validate-a2ml.sh:239-253 📄 .githooks/validate-a2ml.sh:270-280
All validation loops use while IFS= read -r line; do ... done < "$file", which does not process the last line when the file has no trailing newline (read returns non-zero at EOF without a delimiter). A single-line .k9 file containing exactly K9! with no trailing newline would be reported as missing the magic number, and last-line fields (name/version/identity) can be missed — producing false errors or false passes. Process a trailing partial line, e.g. while IFS= read -r line || [[ -n "$line" ]]; do.

✅ Quality: Scripts require bash >= 4.4 despite .githooks/ hook location

📄 .githooks/validate-a2ml.sh:21 📄 .githooks/validate-a2ml.sh:37-51 📄 .githooks/validate-a2ml.sh:292
These scripts use mapfile (bash 4.0+) and reference a potentially-empty array via "${PATHS_IGNORE[@]}" under set -u (safe only on bash 4.4+). CI (ubuntu-latest) runs bash 5, so the workflow is fine, but the .githooks/ location and #!/usr/bin/env bash shebang imply local hook use, and macOS still ships bash 3.2 where mapfile is absent and the empty-array expansion aborts with 'unbound variable'. Consider documenting the bash 4.4+ requirement or guarding the empty-array access (e.g. ${PATHS_IGNORE[@]+"${PATHS_IGNORE[@]}"}).

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}