Commit e6bc474
ci(hypatia): make dogfooding self-scan resilient to upstream outages (#43)
## Context
While completing #42 (now merged), the only red check was **"Hypatia
Neurosymbolic Analysis (Dogfooding)"**. It failed ~11s in — at an
*external* step (BEAM provisioning / cloning / building the upstream
`hyperpolymath/hypatia` scanner), not on anything in this repo. The two
core Agda `check` lanes were green.
That is the wrong behaviour for a scan that is **non-gating by design**
(the workflow already says "warn but don't fail — fix forward"): an
upstream outage was blocking unrelated PRs.
## The principle applied
Distinguish two failure classes and treat them differently:
1. **External-infrastructure failure** (dependency we don't control:
setup-beam, `git clone hypatia`, `mix escript.build`). → Emit a
`::warning::` annotation + a "SKIPPED (non-gating)" job summary, **exit
green**. A contributor's PR must not be hostage to an upstream outage.
2. **Scan findings** (the scanner actually ran). → Unchanged:
fix-forward, still never a hard gate.
## Changes
- `setup-beam` gets `continue-on-error: true`.
- Clone + build consolidated into one tolerant `scanner` step that sets
a `ready` output (never exits non-zero on infra failure).
- `Run Hypatia scan`, `panic-attack`, and artifact upload are gated on
`steps.scanner.outputs.ready == 'true'`.
- New "Note skipped scan" step writes an explicit non-gating explanation
to the job summary when the scanner couldn't be provisioned.
- Header comment documents the two-failure-class policy so future edits
preserve it.
Net effect: the check is green unless the scanner runs *and* we
deliberately decide a finding class should gate (currently none do). The
scan signal is preserved when upstream is healthy; it degrades to a
visible warning when it isn't.
## Verification
- YAML parses (`yaml.safe_load`).
- Logic is conditional-only; no behavioural change to the scan itself
when the scanner provisions successfully.
🤖 Generated with [Claude Code](https://claude.ai/code)
---
_Generated by [Claude
Code](https://claude.ai/code/session_01WLofBeW2eXxD5spRQTSvwi)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent b7f47d2 commit e6bc474
2 files changed
Lines changed: 82 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
59 | 79 | | |
60 | 80 | | |
61 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
4 | 20 | | |
5 | 21 | | |
6 | 22 | | |
| |||
26 | 42 | | |
27 | 43 | | |
28 | 44 | | |
| 45 | + | |
| 46 | + | |
29 | 47 | | |
30 | 48 | | |
31 | 49 | | |
32 | 50 | | |
33 | 51 | | |
34 | | - | |
| 52 | + | |
| 53 | + | |
35 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
36 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
37 | 71 | | |
38 | | - | |
39 | | - | |
40 | 72 | | |
41 | 73 | | |
42 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
43 | 80 | | |
44 | 81 | | |
| 82 | + | |
| 83 | + | |
45 | 84 | | |
46 | 85 | | |
| 86 | + | |
47 | 87 | | |
48 | 88 | | |
49 | 89 | | |
| |||
70 | 110 | | |
71 | 111 | | |
72 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
73 | 127 | | |
| 128 | + | |
74 | 129 | | |
75 | 130 | | |
76 | 131 | | |
| |||
82 | 137 | | |
83 | 138 | | |
84 | 139 | | |
| 140 | + | |
85 | 141 | | |
86 | 142 | | |
87 | 143 | | |
| |||
0 commit comments