ci(hypatia): adopt standards hypatia-scan-reusable wrapper#35
Merged
Conversation
Replace the standalone ~300-line Hypatia scanner with a thin wrapper around hyperpolymath/standards hypatia-scan-reusable.yml, matching governance.yml and scorecard.yml. The reusable is a faithful equivalent: Elixir build, scan, SARIF convert + upload under category `hypatia`, gitbot-fleet Phase 2 submission, advisory critical check, and PR comment. - Pinned to the estate-canonical standards commit 861b5e9 (same as governance.yml / scorecard.yml) so the estate moves in lockstep. - secrets: inherit passes GITHUB_TOKEN + HYPATIA_DISPATCH_PAT through; the PAT is required by the gitbot-fleet Phase 2 learning submission (non-fatal). - Preserves triggers, the concurrency guardrail, the MPL-2.0 header, and the contents:read / security-events:write / pull-requests:write grant (the caller is the ceiling for the reusable's GITHUB_TOKEN). - Hypatia stays advisory (hypatia#213): critical findings surface on the code-scanning page but do not fail the check. Also corrects the file's header comment, which already claimed to be a thin wrapper while still carrying the full inline scanner. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHygjxRyU3WwmXEhA9KF5L
🔍 Hypatia Security ScanFindings: 43 issues detected
View findings[
{
"reason": "Belt.Array deprecated -- use Array (12 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/TextTransform.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.Array2 deprecated -- use Array (1 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/TextTransform.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.String2 deprecated -- use String (9 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/TextTransform.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Belt.Array deprecated -- use Array (11 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/ByteDetector.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.Array2 deprecated -- use Array (2 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/ByteDetector.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.String2 deprecated -- use String (25 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/ByteDetector.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Belt.Array deprecated -- use Array (2 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/PathHandler.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.String2 deprecated -- use String (13 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/core/PathHandler.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Belt.Array deprecated -- use Array (6 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/bindings/Deno.res",
"action": "module_replace",
"rule_module": "migration_rules",
"severity": "high"
},
{
"reason": "Js.Array2 deprecated -- use Array (2 occurrences)",
"type": "deprecated_api",
"file": "/home/runner/work/empty-linter/empty-linter/src/bindings/Deno.res",
"action": "search_replace",
"rule_module": "migration_rules",
"severity": "high"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
marked this pull request as ready for review
June 24, 2026 09:33
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Converts
.github/workflows/hypatia-scan.ymlfrom the full ~300-line standalone scanner into a thin wrapper aroundhyperpolymath/standards/.github/workflows/hypatia-scan-reusable.yml, completing the estate-consistency pattern:governance.yml,scorecard.yml(#34), and nowhypatia-scan.ymlall delegate to the shared reusables, pinned to the same standards commit861b5e9.This is the follow-up flagged in #34.
Why this is safe
I fetched the reusable at
861b5e9and confirmed it is a faithful equivalent of the inline scanner — same 12 steps, no functionality lost:hypatia-findings.jsonartifacthypatiaHYPATIA_DISPATCH_PAT)Key details
secrets: inherit— required by the reusable soGITHUB_TOKENandHYPATIA_DISPATCH_PATflow through; without the PAT the gitbot-fleet Phase 2 submission can't run (it's non-fatal regardless).contents: read,security-events: write,pull-requests: write) — the caller is the ceiling for the reusable'sGITHUB_TOKEN, and these are exactly what its SARIF upload + Dependabot read + PR comment need.How has this been verified?
hypatia-scan-reusable.ymlexists athyperpolymath/standards@861b5e9and inspected its inputs (runs-ononly), itssecrets: inheritrequirement, its top-level permissions, and its step list.yqparse:name, triggers, top-levelpermissions,jobs.scan.uses, andsecrets: inheritall resolve as intended.git diffvsmainis a single file (hypatia-scan.yml, −295/+19).Type of change
🤖 Generated with Claude Code
https://claude.ai/code/session_01AHygjxRyU3WwmXEhA9KF5L
Generated by Claude Code