fix: underscore two unused variables that break --warnings-as-errors

report_generator.ex generate_recommendations/2 never uses its first
argument; verisim_writer.ex build_graph_triples/2 never uses the event in
its index map. Pre-existing warnings, surfaced on CI's forced recompile of
the dependency graph (they had been masked by warm _build caches).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017LDhR8gtnittEWSafunnrq

Author: claude

elixir-mcp/lib/feedback_a_tron/report_generator.ex

@@ -189,9 +189,7 @@ defmodule FeedbackATron.ReportGenerator do
     ## Regressions
 
     #{if length(regressions) > 0 do
-      regressions
-      |> Enum.map(fn r -> "- **#{r.repo}**: #{r.description}" end)
-      |> Enum.join("\n")
+      regressions |> Enum.map(fn r -> "- **#{r.repo}**: #{r.description}" end) |> Enum.join("\n")
     else
       "No regressions detected."
     end}
@@ -227,7 +225,9 @@ defmodule FeedbackATron.ReportGenerator do
   defp delta(_, _), do: "-"
 
   defp format_duration(seconds) when seconds < 60, do: "#{seconds}s"
-  defp format_duration(seconds) when seconds < 3600, do: "#{div(seconds, 60)}m #{rem(seconds, 60)}s"
+
+  defp format_duration(seconds) when seconds < 3600,
+    do: "#{div(seconds, 60)}m #{rem(seconds, 60)}s"
 
   defp format_duration(seconds),
     do: "#{div(seconds, 3600)}h #{div(rem(seconds, 3600), 60)}m"
@@ -238,7 +238,11 @@ defmodule FeedbackATron.ReportGenerator do
     after_h = get_in(session.after_snapshot, ["migration_metrics", "health_score"]) || 0.0
     before_d = get_in(session.before_snapshot, ["migration_metrics", "deprecated_api_count"]) || 0
     after_d = get_in(session.after_snapshot, ["migration_metrics", "deprecated_api_count"]) || 0
-    duration = if session.ended_at, do: DateTime.diff(session.ended_at, session.started_at, :second), else: 0
+
+    duration =
+      if session.ended_at,
+        do: DateTime.diff(session.ended_at, session.started_at, :second),
+        else: 0
 
     "| #{repo} | #{Float.round(after_h - before_h, 3)} | #{before_d - after_d} | #{format_duration(duration)} |"
   end
@@ -301,12 +305,15 @@ defmodule FeedbackATron.ReportGenerator do
     """
   end
 
-  defp generate_recommendations(before, after_m) do
+  defp generate_recommendations(_before, after_m) do
     recs = []
 
     recs =
       if (after_m["deprecated_api_count"] || 0) > 0 do
-        recs ++ ["- Migrate remaining #{after_m["deprecated_api_count"]} deprecated API calls to @rescript/core"]
+        recs ++
+          [
+            "- Migrate remaining #{after_m["deprecated_api_count"]} deprecated API calls to @rescript/core"
+          ]
       else
         recs
       end
@@ -315,7 +322,9 @@ defmodule FeedbackATron.ReportGenerator do
       case after_m["config_format"] do
         f when f in ["BsConfig", "Both"] ->
           recs ++ ["- Migrate bsconfig.json to rescript.json"]
-        _ -> recs
+
+        _ ->
+          recs
       end
 
     recs =

elixir-mcp/lib/feedback_a_tron/verisim_writer.ex

@@ -48,27 +48,25 @@ defmodule FeedbackATron.VeriSimWriter do
     repo_name = extract_repo_name(session.repo_path)
     before_health = get_in(session.before_snapshot, ["migration_metrics", "health_score"]) || 0.0
     after_health = get_in(session.after_snapshot, ["migration_metrics", "health_score"]) || 0.0
-    version_bracket = get_in(session.after_snapshot, ["migration_metrics", "version_bracket"]) || "unknown"
+
+    version_bracket =
+      get_in(session.after_snapshot, ["migration_metrics", "version_bracket"]) || "unknown"
 
     %{
       "schema" => "verisimdb.hexad.v1",
       "hexad_id" => hexad_id,
       "created_at" => now,
-
       "document" => %{
         "title" => "Migration session: #{session.label} (#{repo_name})",
         "body" => build_document_body(session),
         "content_type" => "text/markdown"
       },
-
       "temporal" => %{
         "started_at" => DateTime.to_iso8601(session.started_at),
-        "ended_at" =>
-          if(session.ended_at, do: DateTime.to_iso8601(session.ended_at), else: nil),
+        "ended_at" => if(session.ended_at, do: DateTime.to_iso8601(session.ended_at), else: nil),
         "duration_seconds" => compute_duration(session),
         "event_type" => "rescript_migration_session"
       },
-
       "provenance" => %{
         "source" => "feedback-o-tron",
         "actor" => "migration-observer",
@@ -79,7 +77,6 @@ defmodule FeedbackATron.VeriSimWriter do
           %{"tool" => "panic-attack", "version" => "2.0.0"}
         ]
       },
-
       "semantic" => %{
         "types" => ["rescript_migration", "migration_session", "observatory"],
         "tags" => [
@@ -96,11 +93,9 @@ defmodule FeedbackATron.VeriSimWriter do
           session.events
           |> Enum.count(fn e -> e.type == :issue end)
       },
-
       "graph" => %{
         "triples" => build_graph_triples(hexad_id, session)
       },
-
       "vector" => %{
         "text_for_embedding" => build_embedding_text(session),
         "dimensions" => nil
@@ -174,7 +169,7 @@ defmodule FeedbackATron.VeriSimWriter do
     event_triples =
       session.events
       |> Enum.with_index()
-      |> Enum.map(fn {event, idx} ->
+      |> Enum.map(fn {_event, idx} ->
         event_uri = "#{session_uri}:event:#{idx}"
         [session_uri, "has_event", event_uri]
       end)