Skip to content

ci: vendor validation scripts and remove remote action pins - #60

Merged
hyperpolymath merged 1 commit into
mainfrom
fix-ci-actions
Jul 27, 2026
Merged

ci: vendor validation scripts and remove remote action pins#60
hyperpolymath merged 1 commit into
mainfrom
fix-ci-actions

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Automated PR to fix CI after deleted actions.


Summary by Gitar

  • CI / Workflow updates:
    • Added vendored validation scripts for A2ML and K9 under .githooks/
    • Replaced remote action pins with local script execution in dogfood-gate.yml

This will update automatically on new commits.

Comment thread .githooks/validate-k9.sh
@gitar-bot

gitar-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Vendors validation scripts and updates the CI workflow to execute them locally. Consider ensuring read loops properly process final lines lacking a trailing newline.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

✅ 1 resolved
Edge Case: read loops skip a final line lacking a trailing newline

📄 .githooks/validate-k9.sh:122-131 📄 .githooks/validate-k9.sh:141-150 📄 .githooks/validate-k9.sh:169-183 📄 .githooks/validate-a2ml.sh:102-111 📄 .githooks/validate-a2ml.sh:128-142 📄 .githooks/validate-a2ml.sh:239-253 📄 .githooks/validate-a2ml.sh:270-280
Every content scan uses while IFS= read -r line; do ... done < "$file". read returns non-zero on the last line if the file has no trailing newline, so the loop body never processes that line. A single-line K9! file without a trailing newline would be falsely flagged as missing the magic number, and identity/SPDX fields on an unterminated final line would be missed. Use while IFS= read -r line || [[ -n "$line" ]]; do in the loops in both scripts to handle files that don't end in a newline.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@hyperpolymath
hyperpolymath merged commit c1eb466 into main Jul 27, 2026
23 checks passed
@hyperpolymath
hyperpolymath deleted the fix-ci-actions branch July 27, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant