You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Vendors validation scripts and updates the CI workflow to execute them locally. Consider ensuring read loops properly process final lines lacking a trailing newline.
Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.
✅ 1 resolved✅ Edge Case: read loops skip a final line lacking a trailing newline
📄 .githooks/validate-k9.sh:122-131📄 .githooks/validate-k9.sh:141-150📄 .githooks/validate-k9.sh:169-183📄 .githooks/validate-a2ml.sh:102-111📄 .githooks/validate-a2ml.sh:128-142📄 .githooks/validate-a2ml.sh:239-253📄 .githooks/validate-a2ml.sh:270-280
Every content scan uses while IFS= read -r line; do ... done < "$file". read returns non-zero on the last line if the file has no trailing newline, so the loop body never processes that line. A single-line K9! file without a trailing newline would be falsely flagged as missing the magic number, and identity/SPDX fields on an unterminated final line would be missed. Use while IFS= read -r line || [[ -n "$line" ]]; do in the loops in both scripts to handle files that don't end in a newline.
Options
Auto-apply is off → Gitar will not commit updates to this branch. Display: compact → Showing less information.
Comment with these commands to change the behavior for this request:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to fix CI after deleted actions.
Summary by Gitar
.githooks/dogfood-gate.ymlThis will update automatically on new commits.