ci(workflows): add job-level timeout-minutes (clear Hypatia workflow_audit batch)#35
Merged
Merged
Conversation
Clears the Hypatia `missing_timeout_minutes` (workflow_audit, medium) findings by giving every normal job a job-level timeout-minutes — 23 jobs across 11 workflows. Generous upper bounds that cap runaway jobs without affecting normal runs: boj-build 10, instant-sync 10, dogfood-gate 15, rhodibot 15, scorecard-enforcer 15, codeql 30, casket-pages 30, hypatia-scan 30, release 30, static-analysis-gate 30, cross-platform 30 Reusable-workflow caller jobs (governance, mirror, scorecard, secret-scanner) are intentionally untouched: GitHub rejects timeout-minutes on a job that calls a reusable workflow via `uses:` — that timeout belongs in the called workflow (hyperpolymath/standards), which is out of scope for this repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvsZgNxFbeqfRmrVFNhJ8G
🔍 Hypatia Security ScanFindings: 54 issues detected
View findings[
{
"reason": "Issue in scorecard-enforcer.yml",
"type": "scorecard_publish_with_run_step",
"file": "scorecard-enforcer.yml",
"action": "split_scorecard_publish_job",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in instant-sync.yml",
"type": "secret_action_without_presence_gate",
"file": "instant-sync.yml",
"action": "peter-evans/repository-dispatch",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in scorecard.yml",
"type": "scorecard_wrapper_missing_job_permissions",
"file": "scorecard.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in codeql.yml",
"type": "codeql_missing_actions_language",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "innerHTML assignment -- XSS risk, use textContent or SafeDOM (1 occurrences, CWE-79)",
"type": "js_innerhtml",
"file": "/home/runner/work/game-server-admin/game-server-admin/src/gui/fli/fli-tooltip.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "innerHTML assignment -- XSS risk, use textContent or SafeDOM (1 occurrences, CWE-79)",
"type": "js_innerhtml",
"file": "/home/runner/work/game-server-admin/game-server-admin/src/gui/fli/fli-editable.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "innerHTML assignment -- XSS risk, use textContent or SafeDOM (2 occurrences, CWE-79)",
"type": "js_innerhtml",
"file": "/home/runner/work/game-server-admin/game-server-admin/src/gui/fli/fli-terminal.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "innerHTML assignment -- XSS risk, use textContent or SafeDOM (4 occurrences, CWE-79)",
"type": "js_innerhtml",
"file": "/home/runner/work/game-server-admin/game-server-admin/src/gui/fli/fli-gauge.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "Deno -A grants all permissions -- use specific --allow-* flags (4 occurrences, CWE-250)",
"type": "js_deno_all_perms",
"file": "/home/runner/work/game-server-admin/game-server-admin/run.js",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
},
{
"reason": "HTTP URL in Nickel config -- must use HTTPS (1 occurrences, CWE-319)",
"type": "ncl_http_url",
"file": "/home/runner/work/game-server-admin/game-server-admin/.machine_readable/svc/k9/template-hunt.k9.ncl",
"action": "flag",
"rule_module": "code_safety",
"severity": "high"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
marked this pull request as ready for review
June 20, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add job-level
timeout-minutesacross workflowsClears the recurring Hypatia
missing_timeout_minutes(workflow_audit, medium-severity) findings that have been posting on every PR. Adds a job-leveltimeout-minutesto every normal job — 23 jobs across 11 workflows.Values (generous upper bounds — cap runaway jobs, don't affect normal runs)
boj-build,instant-syncdogfood-gate(×6),rhodibot,scorecard-enforcer(×2)codeql,casket-pages(×2),hypatia-scan,release(×3),static-analysis-gate(×4),cross-platformIntentionally not touched — reusable-workflow callers
governance.yml,mirror.yml,scorecard.yml,secret-scanner.ymlare thin jobs that call a reusable workflow viauses:. GitHub rejectstimeout-minuteson such jobs — the timeout has to live in the called workflow (inhyperpolymath/standards), which is outside this repo. Adding it here would make the workflows invalid, so those four are left as-is.Verification
dogfood-gate.yml's embeddedpython3 -cblock — present identically onmain, unrelated to this change; GitHub's and Hypatia's parsers read it fine, which is why Hypatia flagged its jobs).timeout-minutesis at the 4-space job level; counts match job counts exactly; the four caller files have zero.Scope notes
missing_timeout_minutesbatch only. The 2 critical / 15 high Hypatia findings aren't itemised in the advisory comment and would need the SARIF/artifact detail to triage — separate follow-up.hypatia-scan.yml), so this is hygiene, not a merge-blocker.🤖 Generated with Claude Code
https://claude.ai/code/session_01LvsZgNxFbeqfRmrVFNhJ8G
Generated by Claude Code