Commit c1083db
fix(ci): bump secret-scanner SHA pin to pick up comment-line exemption (#222)
## Summary
- Bumps `secret-scanner-reusable.yml` pin from `3e4bd4c` → `28fdf19`
(standards#236).
- No code change to `scripts/fix-hardcoded-secrets.sh` required: line 11
is a comment (`# Shell: PASSWORD="hardcoded"...`) and the new scanner's
comment-line exemption (layer 3) skips all lines where the leading
non-whitespace character is `#`. Documentation of patterns cannot be
real secrets.
## What changed in standards#236
The `shell-secrets` scanner job in the reusable gained four exemption
layers:
1. Inline pragma (`# scanner-allow: shell-secrets` or `# hypatia: allow
security_errors/secret_detected`) on same or preceding line.
2. `.shell-secrets-ignore` file support (gitignore-style path globs).
3. Automatic param-expansion skip (`${VAR:-}`, `${VAR:?}`, `$VAR`).
4. Comment-line skip (lines starting with `#` cannot hold real secrets).
## Test plan
- [x] Local smoke: `fix-hardcoded-secrets.sh` line 11 skips as comment
line.
- [ ] CI green on this PR (shell-secrets job should now pass on main).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: hyperpolymath <hyperpolymath@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 53d2098 commit c1083db
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
0 commit comments