Skip to content

Commit c54aaee

Browse files
hyperpolymathclaude
andcommitted
fix(ci): drop invalid job-level timeout-minutes from reusable-workflow calls
governance.yml, hypatia-scan.yml, mirror.yml and secret-scanner.yml each set `timeout-minutes:` on a job that calls a reusable workflow via `uses:`. GitHub does not permit that key on a workflow_call job, so it rejected all four files at parse time: each failed instantly (0s, titled by raw filename) on every push and never ran a single job. That silently disabled governance, hypatia scanning, GitLab mirroring and secret scanning on the hub. The standards `*-reusable.yml` workflows already declare `timeout-minutes` on every internal job, so the caller-side key was redundant as well as invalid. Removing it restores the four workflows and matches the already-correct rsr-template-repo pattern. The upstream hypatia rule `missing_timeout_minutes` (lib/rules/workflow_audit.ex) already exempts reusable-call jobs, so these will not be re-flagged. Verified with actionlint (real tool): all four files parse clean, exit 0; zero `timeout-minutes is not available` findings remain on the hub. Part of the estate-wide CI cleanup: 84 repos carry this same dead pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 5804afd commit c54aaee

4 files changed

Lines changed: 1 addition & 8 deletions

File tree

.github/workflows/governance.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,3 @@ permissions:
3232
jobs:
3333
governance:
3434
uses: hyperpolymath/standards/.github/workflows/governance-reusable.yml@412a7031577112b31ee287cc6060179d638d6500 # main 2026-06-27
35-
timeout-minutes: 30

.github/workflows/hypatia-scan.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,4 @@ jobs:
2929
hypatia:
3030
uses: hyperpolymath/standards/.github/workflows/hypatia-scan-reusable.yml@e9c8888769a703924cc3c0d717900960d78aea00
3131
secrets: inherit
32-
# Total caller-side wall-clock cap for the reusable. Matches
33-
# Hypatia's `missing_timeout_minutes` rule expectation. The scan is
34-
# typically ~3 min; the cap leaves headroom for slow estate builds.
35-
timeout-minutes: 30
3632

.github/workflows/mirror.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,3 @@ jobs:
1313
mirror:
1414
uses: hyperpolymath/standards/.github/workflows/mirror-reusable.yml@e9c8888769a703924cc3c0d717900960d78aea00
1515
secrets: inherit
16-
timeout-minutes: 60

.github/workflows/secret-scanner.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,4 @@ jobs:
2020
pull-requests: write
2121
actions: read
2222
uses: hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@e9c8888769a703924cc3c0d717900960d78aea00
23-
secrets: inherit
24-
timeout-minutes: 20
23+
secrets: inherit

0 commit comments

Comments
 (0)