Commit d619a2a
fix(ci): resolve 27 hypatia workflow-hygiene findings (gitbot-fleet#249)
Triggered by the hypatia scan comment on PR #249 (98 findings; this PR
clears the 27 fixable workflow + config findings, plus the ~9 CSA001
mirrors that resolve via the source findings).
Findings resolved:
- 1× unpinned_action — pin governance.yml `@main` → SHA pin matching
estate convention (live standards main 3b3549e2 with date comment).
- 23× missing_timeout_minutes — 16 workflow files, every job +
reusable-workflow caller gets `timeout-minutes:` (10-60 min depending
on job nature: 60 for codeql + mirror + supervised-scan, 30 for
most scans, 10-15 for small jobs).
- 1× codeql_missing_actions_language / 1× StaticAnalysis (same finding,
two presentations) — drop `javascript-typescript` (not in repo); add
`actions` to cover the GitHub Actions surface.
- 1× scorecard_publish_with_run_step (HIGH severity) — split
scorecard-enforcer.yml into action-only `scorecard` job + downstream
`score-gate` job that pulls the SARIF as artifact. Keeps the OpenSSF
publish protocol clean per hypatia's expectation.
- 1× secret_action_without_presence_gate (HIGH severity) — gate
instant-sync.yml's FARM_DISPATCH_TOKEN usage with
`env.HAS_TOKEN == 'true'` job-level env. Adds an explicit skip-notice
step for the path where the token is absent (forks / PRs from forks).
Out of scope for this PR (separate work, will file issues):
- 6× SD004 (.machine_readable/*.a2ml in wrong location) — hypatia rule
is enforcing a retired layout per the standards CLAUDE.md: canonical
location IS `.machine_readable/` directly, not `.machine_readable/6a2/`.
Filing hypatia issue to fix the stale rule.
- 29× expect_in_hot_path — Rust `.expect()` calls across bots/*. Needs
per-bot review + migration to `?` or `.unwrap_or_else(...)`.
- 1× GS007 — 3 non-main remote branches. Cleanup separate.
- 33× CSA001 + 1× CSA002 — code-scanning-API mirrors of other findings.
Clear automatically when sources clear.
Test plan: hypatia scan should drop from 98 → ~38 findings on next run
(or lower as CSA001 mirrors clear), no critical/high remaining in the
workflow surface.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent bcbe886 commit d619a2a
16 files changed
Lines changed: 69 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
110 | 111 | | |
111 | 112 | | |
112 | 113 | | |
| 114 | + | |
113 | 115 | | |
114 | 116 | | |
115 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| 70 | + | |
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| |||
115 | 117 | | |
116 | 118 | | |
117 | 119 | | |
| 120 | + | |
118 | 121 | | |
119 | 122 | | |
120 | 123 | | |
| |||
179 | 182 | | |
180 | 183 | | |
181 | 184 | | |
| 185 | + | |
182 | 186 | | |
183 | 187 | | |
184 | 188 | | |
| |||
239 | 243 | | |
240 | 244 | | |
241 | 245 | | |
| 246 | + | |
242 | 247 | | |
243 | 248 | | |
244 | 249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| 35 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
17 | 25 | | |
18 | 26 | | |
| 27 | + | |
19 | 28 | | |
20 | 29 | | |
21 | 30 | | |
| |||
30 | 39 | | |
31 | 40 | | |
32 | 41 | | |
| 42 | + | |
33 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| 76 | + | |
75 | 77 | | |
76 | 78 | | |
77 | 79 | | |
| |||
0 commit comments