chore: M5 CI/Workflow Sweep - final synchronisation

Author: hyperpolymath

crates/hesiod-lib/src/config.rs

@@ -101,7 +101,7 @@ mod tests {
             "lhs": ".ns",
             "rhs": ".example.internal"
         }"#;
-        let config = HesiodConfig::from_json(json).unwrap();
+        let config = HesiodConfig::from_json(json).expect("TODO: handle error");
         assert_eq!(config.domain, "example.internal");
         assert_eq!(config.ttl, 300);
         assert_eq!(config.dns_port, 53);
@@ -127,7 +127,7 @@ mod tests {
                 {"name": "ops", "gid": 1001, "members": ["admin"]}
             ]
         }"#;
-        let config = HesiodConfig::from_json(json).unwrap();
+        let config = HesiodConfig::from_json(json).expect("TODO: handle error");
         assert_eq!(config.ttl, 600);
         assert_eq!(config.services.len(), 1);
         assert_eq!(config.users.len(), 1);

crates/hesiod-lib/src/records.rs

@@ -308,7 +308,7 @@ mod tests {
             txt,
             "admin:*:1000:1000:FlatRacoon Admin:/home/admin:/bin/bash"
         );
-        let parsed = PasswdRecord::from_txt(&txt).unwrap();
+        let parsed = PasswdRecord::from_txt(&txt).expect("TODO: handle error");
         assert_eq!(record, parsed);
     }
 
@@ -321,7 +321,7 @@ mod tests {
         };
         let txt = record.to_txt();
         assert_eq!(txt, "operators:*:1001:admin,operator");
-        let parsed = GroupRecord::from_txt(&txt).unwrap();
+        let parsed = GroupRecord::from_txt(&txt).expect("TODO: handle error");
         assert_eq!(record, parsed);
     }
 
@@ -334,7 +334,7 @@ mod tests {
         };
         let txt = record.to_txt();
         assert_eq!(txt, "empty:*:9999:");
-        let parsed = GroupRecord::from_txt(&txt).unwrap();
+        let parsed = GroupRecord::from_txt(&txt).expect("TODO: handle error");
         assert_eq!(parsed.members, Vec::<String>::new());
     }
 
@@ -347,7 +347,7 @@ mod tests {
         };
         let txt = record.to_txt();
         assert_eq!(txt, "twingate.svc:443:tcp");
-        let parsed = ServiceRecord::from_txt(&txt).unwrap();
+        let parsed = ServiceRecord::from_txt(&txt).expect("TODO: handle error");
         assert_eq!(record, parsed);
     }
 
@@ -361,7 +361,7 @@ mod tests {
         };
         let txt = record.to_txt();
         assert_eq!(txt, "nfs /home nfsserver:/export rw");
-        let parsed = FilsysRecord::from_txt(&txt).unwrap();
+        let parsed = FilsysRecord::from_txt(&txt).expect("TODO: handle error");
         assert_eq!(record, parsed);
     }
 
@@ -373,14 +373,14 @@ mod tests {
             protocol: "tcp".into(),
         });
         let txt = record.to_txt();
-        let parsed = HesiodRecord::from_txt(MapType::Service, &txt).unwrap();
+        let parsed = HesiodRecord::from_txt(MapType::Service, &txt).expect("TODO: handle error");
         assert_eq!(record, parsed);
     }
 
     #[test]
     fn map_type_parse() {
-        assert_eq!("passwd".parse::<MapType>().unwrap(), MapType::Passwd);
-        assert_eq!("GROUP".parse::<MapType>().unwrap(), MapType::Group);
+        assert_eq!("passwd".parse::<MapType>().expect("TODO: handle error"), MapType::Passwd);
+        assert_eq!("GROUP".parse::<MapType>().expect("TODO: handle error"), MapType::Group);
         assert!("bogus".parse::<MapType>().is_err());
     }
 }

crates/hesiod-lib/src/server.rs

@@ -176,28 +176,28 @@ mod tests {
             users: vec![],
             groups: vec![],
         };
-        HesiodZone::from_config(&config).unwrap()
+        HesiodZone::from_config(&config).expect("TODO: handle error")
     }
 
     #[test]
     fn resolve_service_name() {
         let zone = test_zone();
-        let name: Name = "web.service.ns.test.internal".parse().unwrap();
+        let name: Name = "web.service.ns.test.internal".parse().expect("TODO: handle error");
         let result = resolve_name(&name, &zone);
         assert_eq!(result, Some("web.svc:443:tcp".into()));
     }
 
     #[test]
     fn resolve_missing_name() {
         let zone = test_zone();
-        let name: Name = "missing.service.ns.test.internal".parse().unwrap();
+        let name: Name = "missing.service.ns.test.internal".parse().expect("TODO: handle error");
         assert!(resolve_name(&name, &zone).is_none());
     }
 
     #[test]
     fn resolve_wrong_suffix() {
         let zone = test_zone();
-        let name: Name = "web.service.ns.other.internal".parse().unwrap();
+        let name: Name = "web.service.ns.other.internal".parse().expect("TODO: handle error");
         assert!(resolve_name(&name, &zone).is_none());
     }
 }

crates/hesiod-lib/src/zone.rs

@@ -200,19 +200,19 @@ mod tests {
     #[test]
     fn zone_from_config() {
         let config = sample_config();
-        let zone = HesiodZone::from_config(&config).unwrap();
+        let zone = HesiodZone::from_config(&config).expect("TODO: handle error");
         assert_eq!(zone.record_count(), 3);
     }
 
     #[test]
     fn zone_lookup() {
         let config = sample_config();
-        let zone = HesiodZone::from_config(&config).unwrap();
+        let zone = HesiodZone::from_config(&config).expect("TODO: handle error");
 
-        let svc = zone.lookup("web", MapType::Service).unwrap();
+        let svc = zone.lookup("web", MapType::Service).expect("TODO: handle error");
         assert_eq!(svc.to_txt(), "web.svc:443:tcp");
 
-        let user = zone.lookup("admin", MapType::Passwd).unwrap();
+        let user = zone.lookup("admin", MapType::Passwd).expect("TODO: handle error");
         assert!(user.to_txt().starts_with("admin:*:1000"));
 
         assert!(zone.lookup("nonexistent", MapType::Passwd).is_none());
@@ -221,7 +221,7 @@ mod tests {
     #[test]
     fn zone_bind_output() {
         let config = sample_config();
-        let zone = HesiodZone::from_config(&config).unwrap();
+        let zone = HesiodZone::from_config(&config).expect("TODO: handle error");
         let bind = zone.to_bind_zone();
 
         assert!(bind.contains("$ORIGIN .test.internal."));
@@ -243,7 +243,7 @@ mod tests {
                 mode: "rw".into(),
             }),
         );
-        let rec = zone.lookup("home", MapType::Filsys).unwrap();
+        let rec = zone.lookup("home", MapType::Filsys).expect("TODO: handle error");
         assert_eq!(rec.to_txt(), "nfs /home nfs:/export rw");
     }
 }