fix: add lib accessors so examples compile#49
Merged
Conversation
basic_usage.rs and mlp_router.rs called methods that didn't exist on the public API (8x E0599). Add thin 1:1 accessor/convenience wrappers: - Orchestrator::current_project() -> delegates to context manager - MLP::input_size() / MLP::output_size() -> getters for private fields - MLP::train_step() -> backward + update, returns the step loss cargo check --examples is now clean (lib was already fine). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library compiles clean; the two examples
basic_usage.rsandmlp_router.rscalled methods that don't exist on the public API (8x E0599 for stale API names).Adds thin 1:1 accessor / convenience wrappers to the lib (preferred approach):
Orchestrator::current_project()— delegates to the context managerMLP::input_size()/MLP::output_size()— getters for private fieldsMLP::train_step(input, target, lr)— runsbackward+update, returns the step losscargo check --examplesis now clean (0 errors).reservoir_demo.rsuntouched.🤖 Generated with Claude Code