Skip to content

Commit c9fd28f

Browse files
fix(ci): bump secret-scanner SHA pin + scanner-allow pragma on test fixture (#377)
## Summary - Bumps `secret-scanner-reusable.yml` pin from `3e4bd4c` → `28fdf19` (standards#236). - Adds `# scanner-allow: shell-secrets` pragma above `export ARANGODB_PASSWORD="testpassword"` in `integration/run-tests.sh`. - `hooks/lib/cache.sh` line 22 (`CICD_CACHE_PASSWORD="${CICD_CACHE_PASSWORD:-}"`) now passes automatically via the new param-expansion exemption — no code change needed there. ## What changed in standards#236 The `shell-secrets` scanner job in the reusable gained four exemption layers: 1. Inline pragma (`# scanner-allow: shell-secrets` or `# hypatia: allow security_errors/secret_detected`) on same or preceding line. 2. `.shell-secrets-ignore` file support (gitignore-style path globs). 3. Automatic param-expansion skip (`${VAR:-}`, `${VAR:?}`, `$VAR` — not literals). 4. Comment-line skip (lines starting with `#` cannot hold real secrets). ## Test plan - [x] Local smoke: all three false-positive lines skip cleanly with the new scanner logic. - [ ] CI green on this PR (shell-secrets job should now pass on main). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 9641125 commit c9fd28f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/secret-scanner.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ permissions:
1515

1616
jobs:
1717
scan:
18-
uses: hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@3e4bd4c93911750727e2e4c66dff859e00079da0
18+
uses: hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@28fdf197963c898e6bb80053c74b8d886f1c189d
1919
secrets: inherit

integration/run-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ run_tests() {
264264
export ARANGODB_URL="http://localhost:8529"
265265
export ARANGODB_DATABASE="cicd_hyper_a_test"
266266
export ARANGODB_USERNAME="root"
267-
# See note above re: `testpassword` being the documented fixture, not a real secret.
267+
# scanner-allow: shell-secrets -- test fixture, not a real credential
268268
export ARANGODB_PASSWORD="testpassword"
269269
export DRAGONFLY_URL="redis://localhost:6379"
270270
export RUST_LOG="${RUST_LOG:-info}"

0 commit comments

Comments
 (0)