revert(scaffold): remove wrong-place adapter emission (standards#89 sub-issue 1) (#23)

The unified transaction-gated adapter belongs to the boj-server cartridge
(boj-server/cartridges/<name>-mcp/adapter/), not to the new -iser repo.

The pilot k9iser confirms this: k9iser has no adapter; its adapter lives
at boj-server/cartridges/k9iser-mcp/adapter/k9iser_adapter.zig.

iseriser PR#12 emitted adapter/<name>_adapter.zig into the new -iser repo
where it had no FFI module to import (`@import("<name>_ffi")` against
nothing), no build.zig, and no cartridge.json. The emitted dispatch was
a stub that discarded tool+body, only two of four advertised protocols
were routed, and a buffer-aliasing bug between dispatchRest and the HTTP
response writer would have corrupted output if any FFI were attached.

Surgical revert:
- Drop generate_unified_adapter (213 lines).
- Drop the call site and its doc-comment marker.
- Update test threshold 22 → 21 (base + regen workflow only).
- Drop the adapter-existence assertion in test_files_written_to_disk.
- Update the CI/CD generator header to document why the adapter is not
  emitted here and where it belongs (cartridge-skeleton codegen is
  tracked under standards#89 Phase 2b).

Keeps generate_regen_workflow unchanged — .github/workflows/<name>-regen.yml
correctly belongs in the -iser repo (it triggers the cartridge in boj-server).

Verification: cargo build clean; cargo test 49 unit + 9 integration green.

Refs hyperpolymath/standards#90

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: hyperpolymath

src/codegen/scaffold.rs

@@ -58,8 +58,6 @@ pub fn scaffold_repo(manifest: &Manifest, output_dir: &Path) -> ScaffoldResult {
     files.push(generate_ci_workflow(&model, &iser_name));
     // Regeneration trigger (boj-server cartridge pattern, standards#89 sub-issue 1)
     files.push(generate_regen_workflow(&iser_name));
-    // Unified transaction-gated adapter (single loopback port, SSE, standards#89 sub-issue 1)
-    files.push(generate_unified_adapter(&model, &iser_name));
 
     // Documentation and governance
     files.push(generate_readme(manifest, &model, &iser_name));
@@ -792,8 +790,13 @@ fn test_codegen_output() {{
 // ---------------------------------------------------------------------------
 
 // ---------------------------------------------------------------------------
-// File generators — CI/CD (regeneration trigger + unified adapter)
+// File generators — CI/CD (regeneration trigger)
 // ---------------------------------------------------------------------------
+//
+// The unified transaction-gated adapter belongs to the boj-server cartridge
+// for this -iser (e.g. boj-server/cartridges/<name>-mcp/adapter/), NOT to the
+// -iser repo itself.  Scaffolding the cartridge skeleton is tracked
+// separately under standards#89 Phase 2b — see iseriser ROADMAP.
 
 /// Generate `.github/workflows/<iser_name>-regen.yml` — the central-trigger
 /// workflow that fires the boj-server cartridge to regenerate `generated/*`
@@ -852,220 +855,6 @@ jobs:
     }
 }
 
-/// Generate `adapter/<iser_name>_adapter.zig` — the unified transaction-gated
-/// BoJ adapter (single loopback listener, SSE + REST + GraphQL + gRPC-compat,
-/// one gated dispatch → one Zig ABI).
-///
-/// Replaces the ssg-era 3-parallel-port adapter estate-wide as of standards#89
-/// sub-issue 1 (pilot: k9iser-mcp, boj-server#73).  Internal-only per ADR-0004:
-/// the public surface is the http-capability-gateway (tier-2).
-fn generate_unified_adapter(model: &LanguageModel, iser_name: &str) -> GeneratedFile {
-    let content = format!(
-        r#"// SPDX-License-Identifier: PMPL-1.0-or-later
-// Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk>
-//
-// {iser_name}/adapter/{iser_name}_adapter.zig
-//
-// INTERNAL-ONLY unified transaction-gated adapter.  Per ADR-0004 the only
-// governed public surface is the http-capability-gateway (tier-2) in front;
-// cartridge adapters bind loopback and sit behind it.
-//
-//   One listener, one port, protocol-routed:
-//     POST /invoke            → REST            (JSON in/out)
-//     POST /sse               → SSE             (text/event-stream)
-//     POST /graphql           → GraphQL         (op parsed from body)
-//     POST /grpc/<Svc>/<Mthd> → gRPC-compat     (tool = method)
-//
-// Every request passes the transaction gate (exposureGate, mirroring the
-// Idris2 `exposureSatisfied` contract) BEFORE dispatch.  No request reaches
-// the ABI ungated — estate interface-safety policy.
-//
-// Generated by iseriser for {lang_name} (standards#89 sub-issue 1).
-// Pattern source: k9iser-mcp, boj-server#73.
-
-const std = @import("std");
-const ffi = @import("{iser_name}_ffi");
-
-// Loopback-only by construction: fronted by http-capability-gateway (ADR-0004).
-const BIND_IP = [4]u8{{ 127, 0, 0, 1 }};
-const PORT: u16 = 9390; // Override in cartridge manifest if port conflicts.
-
-// ── Transaction gate (mirrors Idris2 {module_name}.exposureSatisfied) ──────
-//
-// Encoding: 0=Public 1=Authenticated 2=Internal.
-const Exposure = enum(u8) {{ public = 0, authenticated = 1, internal = 2 }};
-
-// Default: require Public (for unauthenticated cartridges).
-// Set to .authenticated for credential-bearing cartridges.
-const REQUIRED_EXPOSURE: Exposure = .public;
-
-/// Zig mirror of Idris2 `exposureSatisfied`.  Cross-checked by the truth-table
-/// test below; the Idris2 module is the source-of-truth contract.
-fn exposureSatisfied(required: Exposure, presented: Exposure, is_local: bool) bool {{
-    if (is_local) return true;
-    return switch (required) {{
-        .public => true,
-        .authenticated => presented == .authenticated or presented == .internal,
-        .internal => presented == .internal,
-    }};
-}}
-
-/// Parse the `X-Trust-Level` header the gateway/sidecar injects.
-fn presentedExposure(req: []const u8) Exposure {{
-    const val = headerValue(req, "x-trust-level") orelse return .public;
-    if (eqIgnoreCase(val, "internal")) return .internal;
-    if (eqIgnoreCase(val, "authenticated")) return .authenticated;
-    return .public;
-}}
-
-// ── Request routing ──────────────────────────────────────────────────────────
-
-fn dispatchTool(tool: []const u8, body: []const u8, resp: []u8) struct {{ status: u16, body: []u8 }} {{
-    _ = body;
-    // Route to the {iser_name}_ffi ABI symbol.  Extend as tools are added.
-    _ = tool;
-    const msg = std.fmt.bufPrint(resp, "{{{{\"tool\":\"{iser_name}\",\"status\":\"dispatched\"}}}}", .{{}}) catch resp[0..0];
-    return .{{ .status = 200, .body = msg }};
-}}
-
-fn dispatchRest(path: []const u8, body: []const u8, is_local: bool, req: []const u8, resp: []u8) struct {{ status: u16, body: []u8 }} {{
-    const presented = presentedExposure(req);
-    if (!exposureSatisfied(REQUIRED_EXPOSURE, presented, is_local)) {{
-        const msg = std.fmt.bufPrint(resp, "{{{{\"error\":\"forbidden\"}}}}", .{{}}) catch resp[0..0];
-        return .{{ .status = 403, .body = msg }};
-    }}
-    const prefix = "/invoke";
-    if (std.mem.startsWith(u8, path, prefix)) {{
-        // Extract tool name from JSON body field "tool".
-        const tool = jsonField(body, "tool") orelse "unknown";
-        return dispatchTool(tool, body, resp);
-    }}
-    const msg = std.fmt.bufPrint(resp, "{{{{\"error\":\"not found\"}}}}", .{{}}) catch resp[0..0];
-    return .{{ .status = 404, .body = msg }};
-}}
-
-fn dispatchSse(body: []const u8, is_local: bool, req: []const u8, stream: std.net.Stream) void {{
-    const presented = presentedExposure(req);
-    if (!exposureSatisfied(REQUIRED_EXPOSURE, presented, is_local)) {{
-        _ = stream.write("HTTP/1.1 403 Forbidden\r\n\r\n") catch {{}};
-        return;
-    }}
-    const tool = jsonField(body, "tool") orelse "unknown";
-    _ = stream.write("HTTP/1.1 200 OK\r\nContent-Type: text/event-stream\r\nCache-Control: no-cache\r\n\r\n") catch {{}};
-    var buf: [256]u8 = undefined;
-    const event = std.fmt.bufPrint(&buf, "data: {{{{\"tool\":\"{iser_name}\",\"dispatched\":\"{{}}\"}}}}\n\n", .{{tool}}) catch &buf;
-    _ = stream.write(event) catch {{}};
-}}
-
-// ── TCP listener ─────────────────────────────────────────────────────────────
-
-fn handleConnection(stream: std.net.Stream) void {{
-    defer stream.close();
-    var buf: [4096]u8 = undefined;
-    const n = stream.read(&buf) catch return;
-    const req = buf[0..n];
-
-    const is_local = true; // All connections via loopback are locally trusted.
-
-    const path_start = std.mem.indexOf(u8, req, " ") orelse return;
-    const path_end = std.mem.indexOf(u8, req[path_start + 1 ..], " ") orelse return;
-    const path = req[path_start + 1 .. path_start + 1 + path_end];
-
-    var resp_buf: [2048]u8 = undefined;
-
-    if (std.mem.startsWith(u8, path, "/sse")) {{
-        const body = extractBody(req);
-        dispatchSse(body, is_local, req, stream);
-    }} else {{
-        const body = extractBody(req);
-        const result = dispatchRest(path, body, is_local, req, &resp_buf);
-        const http = std.fmt.bufPrint(&resp_buf, "HTTP/1.1 {{}} OK\r\nContent-Type: application/json\r\n\r\n{{s}}", .{{ result.status, result.body }}) catch &resp_buf;
-        _ = stream.write(http) catch {{}};
-    }}
-}}
-
-pub fn main() !void {{
-    const addr = std.net.Address.initIp4(BIND_IP, PORT);
-    var server = try addr.listen(.{{ .reuse_address = true }});
-    defer server.deinit();
-    std.log.info("{iser_name} unified adapter listening on 127.0.0.1:{{}} (loopback-only, ADR-0004)", .{{PORT}});
-    while (true) {{
-        const conn = server.accept() catch continue;
-        const t = std.Thread.spawn(.{{}}, handleConnection, .{{conn.stream}}) catch continue;
-        t.detach();
-    }}
-}}
-
-// ── Helpers ──────────────────────────────────────────────────────────────────
-
-fn headerValue(req: []const u8, name: []const u8) ?[]const u8 {{
-    var lines = std.mem.splitScalar(u8, req, '\n');
-    while (lines.next()) |line| {{
-        if (eqIgnoreCase(line[0..@min(name.len, line.len)], name)) {{
-            const col = std.mem.indexOf(u8, line, ":") orelse continue;
-            return std.mem.trim(u8, line[col + 1 ..], &std.ascii.whitespace);
-        }}
-    }}
-    return null;
-}}
-
-fn eqIgnoreCase(a: []const u8, b: []const u8) bool {{
-    if (a.len != b.len) return false;
-    for (a, b) |ca, cb| {{
-        if (std.ascii.toLower(ca) != std.ascii.toLower(cb)) return false;
-    }}
-    return true;
-}}
-
-fn jsonField(body: []const u8, key: []const u8) ?[]const u8 {{
-    var search_buf: [64]u8 = undefined;
-    const needle = std.fmt.bufPrint(&search_buf, "\"{{}}\": \"", .{{key}}) catch return null;
-    const start = std.mem.indexOf(u8, body, needle) orelse return null;
-    const val_start = start + needle.len;
-    const val_end = std.mem.indexOf(u8, body[val_start..], "\"") orelse return null;
-    return body[val_start .. val_start + val_end];
-}}
-
-fn extractBody(req: []const u8) []const u8 {{
-    const sep = "\r\n\r\n";
-    const pos = std.mem.indexOf(u8, req, sep) orelse return req;
-    return req[pos + sep.len ..];
-}}
-
-// ── Tests ────────────────────────────────────────────────────────────────────
-
-test "exposureSatisfied: loopback always passes" {{
-    try std.testing.expect(exposureSatisfied(.internal, .public, true));
-    try std.testing.expect(exposureSatisfied(.authenticated, .public, true));
-}}
-
-test "exposureSatisfied: public gate passes all" {{
-    try std.testing.expect(exposureSatisfied(.public, .public, false));
-    try std.testing.expect(exposureSatisfied(.public, .authenticated, false));
-    try std.testing.expect(exposureSatisfied(.public, .internal, false));
-}}
-
-test "exposureSatisfied: authenticated gate rejects public" {{
-    try std.testing.expect(!exposureSatisfied(.authenticated, .public, false));
-    try std.testing.expect(exposureSatisfied(.authenticated, .authenticated, false));
-    try std.testing.expect(exposureSatisfied(.authenticated, .internal, false));
-}}
-
-test "exposureSatisfied: internal gate rejects public and authenticated" {{
-    try std.testing.expect(!exposureSatisfied(.internal, .public, false));
-    try std.testing.expect(!exposureSatisfied(.internal, .authenticated, false));
-    try std.testing.expect(exposureSatisfied(.internal, .internal, false));
-}}
-"#,
-        iser_name = iser_name,
-        lang_name = model.name,
-        module_name = idris2_module_name(model),
-    );
-    GeneratedFile {
-        path: PathBuf::from(format!("adapter/{iser_name}_adapter.zig")),
-        content,
-    }
-}
 
 /// Generate `.github/workflows/ci.yml` for the new -iser.
 fn generate_ci_workflow(_model: &LanguageModel, iser_name: &str) -> GeneratedFile {
@@ -1380,10 +1169,11 @@ description = "Chapel distributed computing -iser"
         );
         let repo = result.repo().unwrap();
         assert_eq!(repo.name, "chapeliser");
-        // 22+ files: 20 base + regen workflow + unified adapter (standards#89 sub-issue 1)
+        // 21+ files: 20 base + regen workflow (standards#89 sub-issue 1).
+        // The unified adapter belongs to the boj-server cartridge, not this repo.
         assert!(
-            repo.file_count() >= 22,
-            "expected 22+ files, got {}",
+            repo.file_count() >= 21,
+            "expected 21+ files, got {}",
             repo.file_count()
         );
     }
@@ -1429,9 +1219,9 @@ description = "Chapel distributed computing -iser"
         assert!(repo_root.join("src/interface/abi/Types.idr").exists());
         assert!(repo_root.join("ffi/zig/src/main.zig").exists());
         assert!(repo_root.join(".github/workflows/ci.yml").exists());
-        // standards#89 sub-issue 1: regen trigger + unified adapter
+        // standards#89 sub-issue 1: regen trigger only.
+        // The unified adapter belongs to the boj-server cartridge, not this repo.
         assert!(repo_root.join(".github/workflows/chapeliser-regen.yml").exists());
-        assert!(repo_root.join("adapter/chapeliser_adapter.zig").exists());
         assert!(repo_root.join("README.adoc").exists());
         assert!(repo_root.join("LICENSE").exists());
     }