Skip to content

Commit 27238db

Browse files
committed
ci: fix pre-existing failures so PR checks can actually pass
Four CI checks failed on every PR (and on main) for reasons unrelated to any code change — the "CI that cannot pass" problem. Fix each: - rust-ci.yml: the job calls the shared reusable rust-ci-reusable.yml with no `with:` block, so its required `toolchain` input was empty and the "parse toolchain version" step failed with `'toolchain' is a required input`. Pass `toolchain: stable` (matches .tool-versions and the dtolnay/rust-toolchain pins in e2e.yml). - tests/aspect/cross_cutting_test.sh: the Documentation check asserted README.adoc, but the repo ships README.md (root .adoc is EXPLAINME.adoc). Accept either; aspect suite now PASS 29 / FAIL 0. - cargo-audit.yml create-issue: `needs: audit` + `if: failure()` ran on PR events where GITHUB_TOKEN is read-only, so `gh issue create` 403'd. Guard with `&& github.event_name != 'pull_request'`; issues are still filed on push/schedule runs. Both workflow files keep their SPDX line-1 header and top-level permissions block (workflow-linter.yml requirements); YAML validated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015qwVESTcbfanY2iJPQNoSz
1 parent 71a9456 commit 27238db

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

.github/workflows/cargo-audit.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ jobs:
3838
runs-on: ubuntu-latest
3939
timeout-minutes: 15
4040
needs: audit
41-
if: failure()
41+
# Only file a tracking issue on push/schedule runs. On pull_request events
42+
# GITHUB_TOKEN is forced read-only, so `gh issue create` 403s; guarding here
43+
# keeps PR runs green (the audit job itself still gates the PR).
44+
if: failure() && github.event_name != 'pull_request'
4245
permissions:
4346
issues: write
4447
steps:

.github/workflows/rust-ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,5 @@ permissions:
1515
jobs:
1616
rust-ci:
1717
uses: hyperpolymath/standards/.github/workflows/rust-ci-reusable.yml@d135b05bfc647d0c0fbfedc7e80f37ea50f49236
18+
with:
19+
toolchain: stable

tests/aspect/cross_cutting_test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ check "No unsafe in reversible-core" "! grep -rh 'unsafe' '${JK_DIR}/crates/reve
5151

5252
# --- Documentation ---
5353
echo "--- Documentation ---"
54-
check "README.adoc exists" "[ -f '${JK_DIR}/README.adoc' ]"
54+
check "README exists" "[ -f '${JK_DIR}/README.md' ] || [ -f '${JK_DIR}/README.adoc' ]"
5555
check "SECURITY.md exists" "[ -f '${JK_DIR}/SECURITY.md' ]"
5656
check "ARCHITECTURE.md exists" "[ -f '${JK_DIR}/ARCHITECTURE.md' ]"
5757
check "PROOF-NEEDS.md exists" "[ -f '${JK_DIR}/PROOF-NEEDS.md' ]"

0 commit comments

Comments
 (0)