Skip to content

Commit 951cc91

Browse files
ci(antipattern): broaden TS allowlist (cli, mod.ts, lsp-server, *vscode*, deno-*) (#2)
Same fleet-wide v2 patch as previously rolled out — adds /cli/, mod.ts, lsp-server.ts, broader *vscode*, /deno-*/ patterns.
1 parent 5a03e0d commit 951cc91

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

.github/workflows/rsr-antipattern.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,16 @@ jobs:
1919
- name: Check for TypeScript
2020
run: |
2121
# Allowlist (TS legitimate as a bridge/adapter to a non-ReScript ecosystem):
22-
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI to ReScript core)
23-
# *.d.ts - TypeScript type declarations for ReScript FFI
24-
# tests/, test/ - Deno test runners verifying ReScript output
25-
# scripts/ - Deno build scripts (bundle, dev-server, etc.)
26-
# mcp-adapter/ - MCP server adapters (MCP protocol is Deno/TS-typed by spec)
27-
# vscode/ - VSCode extensions (TS is the ecosystem default)
22+
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI)
23+
# *.d.ts - TypeScript type declarations for ReScript FFI
24+
# tests/, test/ - Deno test runners
25+
# scripts/ - Deno build scripts
26+
# mcp-adapter/ - MCP server adapters (MCP is Deno/TS-typed by spec)
27+
# *vscode* - VSCode extensions (TS is the ecosystem default)
28+
# cli/ - CLI entry points (Deno scripts)
29+
# mod.ts - canonical Deno module entrypoint
30+
# *lsp-server.ts, *lsp.ts - Language Server Protocol implementations
31+
# deno-*/ - subprojects explicitly named for Deno
2832
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) \
2933
| grep -v node_modules \
3034
| grep -v '/bindings/' \
@@ -33,7 +37,12 @@ jobs:
3337
| grep -v '/test/' \
3438
| grep -v '/scripts/' \
3539
| grep -v '/mcp-adapter/' \
36-
| grep -v '/vscode/' \
40+
| grep -Ev '/[^/]*vscode[^/]*/' \
41+
| grep -v '/cli/' \
42+
| grep -v '/mod\.ts$' \
43+
| grep -Ev 'lsp[-_]?server\.ts$' \
44+
| grep -Ev '[/-]lsp\.ts$' \
45+
| grep -Ev '/deno-[^/]+/' \
3746
|| true)
3847
if [ -n "$TS_FILES" ]; then
3948
echo "❌ TypeScript files detected - use ReScript instead"

0 commit comments

Comments
 (0)