Skip to content

Commit 19c7624

Browse files
hyperpolymathclaude
andcommitted
fix(ci): remove the unrunnable SonarCloud step breaking Governance + CodeQL
`SonarSource/sonarqube-scan-action@master` was appended to four workflows by a sweep. The root copy is live and breaks CI two different ways: - governance / Workflow security linter ERROR: Found unpinned actions: .github/workflows/codeql.yml:58: uses: SonarSource/sonarqube-scan-action@master - CodeQL Security Analysis ##[error]The action sonarsource/sonarqube-scan-action@master is not allowed in hyperpolymath/maa-framework because all actions must be pinned to a full-length commit SHA. The second is a *startup* rejection by the org ruleset, so the analyze job died with zero steps — no lint-shaped error, and no check run to inspect. Removed rather than pinned, because pinning alone cannot make it work: - no `SONAR_TOKEN` secret exists on this repo (verified via `gh secret list`) - no sonar-project.properties / sonar config anywhere in the tree - the step carries no `with:` or `env:`, so it has no project key or org - it was appended *inside the CodeQL matrix job*, so it would run once per language, and in two files it was jammed between a step and the next job key with no blank line Pinning it would have swapped a pin error for an auth error and left main red. Also removes the three copies under aletheia/ — those workflows are inert (Actions reads .github/workflows/ at the repo root only), but leaving them would re-introduce the defect the moment anyone promotes one to the root. Restores the trailing newlines the sweep dropped. To adopt SonarCloud properly later: one root workflow only, pinned to a SHA, with SONAR_TOKEN wired and a sonar-project.properties committed. Verified: all four files parse (`yq`); job keys intact (test/security/coverage, check/test/build/self-verify); both governance linter checks pass locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 7b6a293 commit 19c7624

4 files changed

Lines changed: 0 additions & 10 deletions

File tree

.github/workflows/codeql.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,3 @@ jobs:
5353
uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v3
5454
with:
5555
category: "/language:${{ matrix.language }}"
56-
57-
- name: SonarCloud Scan
58-
uses: SonarSource/sonarqube-scan-action@master

aletheia/.github/workflows/codeql.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,3 @@ jobs:
4040
uses: github/codeql-action/analyze@662472033e021d55d94146f66f6058822b0b39fd # v3.28.1
4141
with:
4242
category: "/language:${{ matrix.language }}"
43-
44-
- name: SonarCloud Scan
45-
uses: SonarSource/sonarqube-scan-action@master

aletheia/.github/workflows/rust-ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ jobs:
2828
- name: Build release
2929
run: cargo build --release
3030

31-
- name: SonarCloud Scan
32-
uses: SonarSource/sonarqube-scan-action@master
3331
security:
3432
runs-on: ubuntu-latest
3533
timeout-minutes: 15

aletheia/extraction/rhodibot/.github/workflows/ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ jobs:
4545
exit 1
4646
fi
4747
48-
- name: SonarCloud Scan
49-
uses: SonarSource/sonarqube-scan-action@master
5048
test:
5149
name: Test
5250
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)