Skip to content

Commit 2b56c52

Browse files
hyperpolymathmistral-vibeclaude
authored
fix(ada): make the Ada modshells build (it had never compiled) (#67)
## What Makes the Ada `modshells` implementation actually compile, so it can be deployed as the canonical binary. The Ada sources had never built. ## Fixes - **`modshells.adb`** — add `use type Shell_Manager.Shell_Status` so the enum `=` operator is directly visible. - **`config_store.adb`** — `Ada.Environment_Variables.Value` returns `String` (not `String_Access`); use `Exists`+`Value`. Drop the nonexistent `Ada.Directories.Separator` (use `'/'`). Correct the default config root to `~/.config/modshells` (was a stray `~/.config/nushell/modshells` that would mis-scaffold). - **`shell_manager.adb`** — fix 32 invalid Ada string escapes (`\"` → `""`) in the shell-sourcing-block generator; same `Value`/separator fixes; qualify the ambiguous `Ada.Directories.Name_Error | Use_Error`. - **`modshells.gpr`** — point `Main` at `modshells.adb` (was a package body). ## Build Builds clean with `gnatmake` (FSF GNAT 13.3): ``` gnatmake -o bin/modshells src/main/modshells.adb \ -Isrc/main -Isrc/config_store -Isrc/shell_manager -Isrc/shell_validator -D obj ``` `gprbuild` is separately broken in this environment (GPRBUILD Pro 18.0w cannot find the FSF compiler) — not addressed here. ## Verification Sandbox-tested (isolated `$HOME` + `MODSHELLS_CONFIG_PATH`): creates the `core/tools/misc/os/ui` structure, detects shells, and injects sourcing blocks with correct quoting, backing up rc files first. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Mistral Vibe <vibe@mistral.ai> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent e886b83 commit 2b56c52

44 files changed

Lines changed: 312 additions & 56 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.claude/CLAUDE.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!--
2+
SPDX-License-Identifier: MPL-2.0
3+
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
4+
-->
15
## Machine-Readable Artefacts
26

37
The following files in `.machine_readable/` contain structured project metadata:
@@ -61,7 +65,7 @@ Both are FOSS with independent governance (no Big Tech).
6165
### Enforcement Rules
6266

6367
1. **No new TypeScript files** - Convert existing TS to AffineScript
64-
2. **No package.json for runtime deps** - Use deno.json imports
68+
2. **No package.json - use deno.json deps** - Use deno.json imports
6569
3. **No node_modules in production** - Deno caches deps automatically
6670
4. **No Go code** - Use Rust instead
6771
5. **No Python anywhere** - Use Julia for data/batch, Rust for systems, AffineScript for apps

‎.github/CODEOWNERS‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# SPDX-License-Identifier: MPL-2.0
2+
# CODEOWNERS - Define code review assignments for GitHub
3+
# See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
4+
5+
# Default: sole maintainer for all files
6+
* @hyperpolymath
7+
8+
# Security-sensitive files require explicit ownership
9+
SECURITY.md @hyperpolymath
10+
.github/workflows/ @hyperpolymath
11+
.machine_readable/ @hyperpolymath
12+
contractiles/ @hyperpolymath
13+
14+
# License files
15+
LICENSE @hyperpolymath
16+
LICENSES/ @hyperpolymath
17+
18+
# Configuration
19+
.gitignore @hyperpolymath
20+
.github/ @hyperpolymath
21+
22+
# Documentation
23+
README* @hyperpolymath
24+
CONTRIBUTING* @hyperpolymath
25+
CODE_OF_CONDUCT* @hyperpolymath
26+
GOVERNANCE* @hyperpolymath
27+
MAINTAINERS* @hyperpolymath
28+
CHANGELOG* @hyperpolymath
29+
ROADMAP* @hyperpolymath
30+
31+
# Build and CI
32+
Justfile @hyperpolymath
33+
Makefile @hyperpolymath
34+
*.sh @hyperpolymath

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!--
2+
SPDX-License-Identifier: MPL-2.0
3+
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
4+
-->
15
---
26
name: Bug report
37
about: Create a report to help us improve

‎.github/ISSUE_TEMPLATE/custom.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!--
2+
SPDX-License-Identifier: MPL-2.0
3+
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
4+
-->
15
---
26
name: Custom issue template
37
about: Describe this issue template's purpose here.

‎.github/ISSUE_TEMPLATE/documentation.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!--
2+
SPDX-License-Identifier: MPL-2.0
3+
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
4+
-->
15
---
26
name: Documentation
37
about: Report unclear, missing, or incorrect documentation

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!--
2+
SPDX-License-Identifier: MPL-2.0
3+
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
4+
-->
15
---
26
name: Feature request
37
about: Suggest an idea for this project

‎.github/ISSUE_TEMPLATE/question.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!--
2+
SPDX-License-Identifier: MPL-2.0
3+
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
4+
-->
15
---
26
name: Question
37
about: Ask a question about usage or behaviour

‎.github/copilot/coding-agent.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
mcp_servers:
2+
boj-server:
3+
command: npx
4+
args: ["-y", "@hyperpolymath/boj-server@latest"]
5+
env:
6+
BOJ_URL: http://localhost:7700

‎.github/workflows/ada.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
contents: read
1616

1717
runs-on: ubuntu-latest
18+
timeout-minutes: 15
1819

1920
steps:
2021
- name: Checkout

‎.github/workflows/codeql.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ permissions: read-all
2323
jobs:
2424
analyze:
2525
runs-on: ubuntu-latest
26+
timeout-minutes: 15
2627
permissions:
2728
contents: read
2829
security-events: write

0 commit comments

Comments
 (0)