Skip to content

chore: fill or remove RSR template placeholders - #60

Merged
hyperpolymath merged 6 commits into
mainfrom
fix/rsr-placeholders
Jul 28, 2026
Merged

chore: fill or remove RSR template placeholders#60
hyperpolymath merged 6 commits into
mainfrom
fix/rsr-placeholders

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

openssf-compliance.yml fails when any of the thirteen files it checks still contains a {{PLACEHOLDER}} token. This clears them, with no invention.

  • Deleted the TEMPLATE INSTRUCTIONS (delete this block before publishing) comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.
  • Filled what the repository itself supplies: owner and repo from the git remote, project name, year, forge, main branch, contact email.
  • Removed PGP and website lines. https://github.com/<user>.gpg returns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previous just init copied already-filled templates out of squisher-corpus, so 51 repositories directed vulnerability reports to hyperpolymath/squisher-corpus — a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.

hyperpolymath and others added 5 commits July 26, 2026 14:48
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.

Three kinds of change, no invention:

The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.

Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.

PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

CI failed: 4 CI validation and workflow failures caused by missing manifest identity fields, K9 contract errors, a missing OpenSSF compliance file (.machine_readable/STATE.a2ml), and an invalid CodeQL action SHA reference.

Overview

Multiple validation and workflow checks failed due to missing required files, contract/manifest errors, and an invalid GitHub Actions SHA reference across 4 jobs.

Failures

A2ML Validation Failure (confidence: high)

  • Type: build
  • Affected jobs: 90326792881
  • Related to change: yes
  • Root cause: The file .github/0.1-AI-MANIFEST.a2ml lacks required identity fields (agent-id, name, or project) and an SPDX license identifier.
  • Suggested fix: Add the required identity fields and SPDX-License-Identifier within the first 10 lines of .github/0.1-AI-MANIFEST.a2ml.

K9 Contract Validation Failure (confidence: high)

  • Type: build
  • Affected jobs: 90326792880
  • Related to change: yes
  • Root cause: Scanned K9 contract files failed validation due to missing the 'K9!' magic number, missing pedigree blocks, or missing name/version fields.
  • Suggested fix: Update the K9 contract files to include the 'K9!' magic number, valid pedigree blocks, and required metadata fields.

Invalid CodeQL Action SHA (confidence: high)

  • Type: configuration
  • Affected jobs: 90326793029
  • Related to change: yes
  • Root cause: The workflow references a non-existent commit SHA for github/codeql-action (29b1f65c1f735799893313399435a59f54045865).
  • Suggested fix: Update the CodeQL action reference in the workflow file to use a valid release tag (e.g., v3) or a valid commit SHA.

OpenSSF Compliance Validation Failure (confidence: high)

  • Type: configuration
  • Affected jobs: 90326793021
  • Related to change: yes
  • Root cause: The OpenSSF compliance workflow failed because the required .machine_readable/STATE.a2ml file is missing.
  • Suggested fix: Create the required .machine_readable/STATE.a2ml file.

Summary

  • Change-related failures: 4 validation and configuration failures (A2ML manifest, K9 contracts, CodeQL action SHA, and OpenSSF compliance).
  • Infrastructure/flaky failures: 0
  • Recommended action: Fix the missing manifest fields, correct the K9 contract files, supply the missing .machine_readable/STATE.a2ml file, and update the CodeQL action reference to a valid version.
Code Review ✅ Approved 1 resolved / 1 findings

Fills RSR template placeholders and updates security compliance workflows, but the Guix package definition incorrectly identifies the package as squisher-corpus instead of natsci-studio.

✅ 1 resolved
Bug: guix.scm identifies package as squisher-corpus, not natsci-studio

📄 guix.scm:2 📄 guix.scm:10 📄 guix.scm:14-16
This guix.scm lives in the natsci-studio repo (git remote and 0-AI-MANIFEST.a2ml both confirm the name is natsci-studio), yet its name, synopsis, description, and home-page all point to "squisher-corpus" (home-page https://github.com/hyperpolymath/squisher-corpus). This is the same squisher-corpus misroute the PR sets out to fix in SECURITY.md, left uncorrected here — guix shell -f guix.scm will present the wrong package identity and link to an unrelated repository. Update the name/synopsis/description/home-page (and the header comment on line 2) to natsci-studio.

Tip

Comment Gitar fix CI to trigger a fix.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Comment thread guix.scm
@hyperpolymath
hyperpolymath merged commit bac41a1 into main Jul 28, 2026
19 of 24 checks passed
@hyperpolymath
hyperpolymath deleted the fix/rsr-placeholders branch July 28, 2026 17:05
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant