chore: fix, Rust, lint/fmt, issues

Batch Justfile audit: standardised naming (lowercase→Justfile),
fixed parse errors, removed useless build-riscv from non-Rust repos,
added missing assail recipe, and fixed code quality issues.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: hyperpolymath

src/abi/mod.rs

@@ -14,21 +14,17 @@ use std::fmt;
 /// Nim can compile to C, C++, or JavaScript.
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "lowercase")]
+#[derive(Default)]
 pub enum CompilationTarget {
     /// Compile to C (default, best for system libraries).
+    #[default]
     C,
     /// Compile to C++ (for C++ interop).
     Cpp,
     /// Compile to JavaScript (for browser/Deno targets).
     Js,
 }
 
-impl Default for CompilationTarget {
-    fn default() -> Self {
-        CompilationTarget::C
-    }
-}
-
 impl fmt::Display for CompilationTarget {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
@@ -43,21 +39,17 @@ impl fmt::Display for CompilationTarget {
 /// ARC and ORC are the modern, deterministic options; None disables GC entirely.
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "lowercase")]
+#[derive(Default)]
 pub enum GcStrategy {
     /// ARC — deterministic reference counting with move semantics.
+    #[default]
     Arc,
     /// ORC — ARC + cycle collector for cyclic data structures.
     Orc,
     /// No GC — fully manual memory management.
     None,
 }
 
-impl Default for GcStrategy {
-    fn default() -> Self {
-        GcStrategy::Arc
-    }
-}
-
 impl fmt::Display for GcStrategy {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
@@ -124,10 +116,7 @@ pub enum NimType {
     /// ref T — traced (GC-managed) reference.
     Ref(Box<NimType>),
     /// array[N, T] — fixed-size array.
-    Array {
-        size: usize,
-        element: Box<NimType>,
-    },
+    Array { size: usize, element: Box<NimType> },
     /// seq[T] — dynamic sequence.
     Seq(Box<NimType>),
     /// object type with named fields.

src/codegen/mod.rs

@@ -118,8 +118,8 @@ pub fn run(manifest: &Manifest, args: &[String]) -> Result<()> {
         );
     }
 
-    println!("Running {} workload: {}", "nimiser", manifest.project.name);
-    let status = std::process::Command::new(&format!("./{}", binary))
+    println!("Running nimiser workload: {}", manifest.project.name);
+    let status = std::process::Command::new(format!("./{}", binary))
         .args(args)
         .status()
         .with_context(|| format!("Failed to run {}", binary))?;

src/codegen/nim_gen.rs

@@ -23,10 +23,7 @@ pub fn generate_nim_source(manifest: &Manifest, procs: &[NimProc]) -> String {
         "# Generated by nimiser for library '{}'",
         manifest.project.name
     ));
-    lines.push(format!(
-        "# Version: {}",
-        manifest.project.version
-    ));
+    lines.push(format!("# Version: {}", manifest.project.version));
     if !manifest.project.description.is_empty() {
         lines.push(format!("# {}", manifest.project.description));
     }

src/codegen/parser.rs

@@ -12,11 +12,7 @@ use crate::manifest::{FunctionConfig, Manifest};
 
 /// Parse all function declarations from a manifest into NimProc ABI types.
 pub fn parse_functions(manifest: &Manifest) -> Result<Vec<NimProc>> {
-    manifest
-        .functions
-        .iter()
-        .map(|f| parse_function(f))
-        .collect()
+    manifest.functions.iter().map(parse_function).collect()
 }
 
 /// Parse a single FunctionConfig into a NimProc.

src/lib.rs

@@ -9,7 +9,7 @@ pub mod abi;
 pub mod codegen;
 pub mod manifest;
 
-pub use manifest::{load_manifest, validate, Manifest};
+pub use manifest::{Manifest, load_manifest, validate};
 
 /// Convenience: load, validate, and generate all artifacts in one call.
 pub fn generate(manifest_path: &str, output_dir: &str) -> anyhow::Result<()> {

src/manifest/mod.rs

@@ -167,8 +167,7 @@ pub struct LegacyOptions {
 pub fn load_manifest(path: &str) -> Result<Manifest> {
     let content = std::fs::read_to_string(path)
         .with_context(|| format!("Failed to read manifest: {}", path))?;
-    toml::from_str(&content)
-        .with_context(|| format!("Failed to parse manifest: {}", path))
+    toml::from_str(&content).with_context(|| format!("Failed to parse manifest: {}", path))
 }
 
 /// Validate the manifest for required fields and logical consistency.
@@ -300,7 +299,10 @@ opt-level = "speed"
 
 /// Print summary information about a loaded manifest.
 pub fn print_info(manifest: &Manifest) {
-    println!("=== {} v{} ===", manifest.project.name, manifest.project.version);
+    println!(
+        "=== {} v{} ===",
+        manifest.project.name, manifest.project.version
+    );
     if !manifest.project.description.is_empty() {
         println!("Description: {}", manifest.project.description);
     }

tests/integration_tests.rs

@@ -51,10 +51,7 @@ fn test_parse_fast_lib_functions() {
     assert_eq!(add.params.len(), 2);
     assert_eq!(add.params[0].name, "a");
     assert_eq!(add.params[0].nim_type, NimType::Primitive("cint".into()));
-    assert_eq!(
-        add.return_type,
-        Some(NimType::Primitive("cint".into()))
-    );
+    assert_eq!(add.return_type, Some(NimType::Primitive("cint".into())));
     assert!(add.pragmas.contains(&NimPragma::Exportc));
     assert!(add.pragmas.contains(&NimPragma::Cdecl));
 
@@ -91,8 +88,9 @@ fn test_generate_nim_source_content() {
         "Missing fast_add proc declaration"
     );
     assert!(
-        nim_source
-            .contains("proc fast_multiply(x: cdouble, y: cdouble): cdouble {.exportc, cdecl, noSideEffect.} ="),
+        nim_source.contains(
+            "proc fast_multiply(x: cdouble, y: cdouble): cdouble {.exportc, cdecl, noSideEffect.} ="
+        ),
         "Missing fast_multiply proc declaration"
     );
     assert!(
@@ -265,10 +263,19 @@ opt-level = "speed"
     let m = manifest::load_manifest(&path).unwrap();
     let cmd = build_gen::build_command_from_manifest(&m, "c_lib.nim", true);
     let rendered = cmd.render();
-    assert!(rendered.starts_with("nim c"), "C backend should use 'nim c'");
+    assert!(
+        rendered.starts_with("nim c"),
+        "C backend should use 'nim c'"
+    );
     assert!(rendered.contains("--gc:arc"), "Should use ARC GC");
-    assert!(rendered.contains("--app:lib"), "C target should compile as library");
-    assert!(rendered.contains("-d:release"), "Release build should have -d:release");
+    assert!(
+        rendered.contains("--app:lib"),
+        "C target should compile as library"
+    );
+    assert!(
+        rendered.contains("-d:release"),
+        "Release build should have -d:release"
+    );
 
     // Test JS + ORC
     let dir2 = TempDir::new().unwrap();
@@ -286,9 +293,15 @@ opt-level = "none"
     let m_js = manifest::load_manifest(&path_js).unwrap();
     let cmd_js = build_gen::build_command_from_manifest(&m_js, "js_lib.nim", false);
     let rendered_js = cmd_js.render();
-    assert!(rendered_js.starts_with("nim js"), "JS backend should use 'nim js'");
+    assert!(
+        rendered_js.starts_with("nim js"),
+        "JS backend should use 'nim js'"
+    );
     assert!(rendered_js.contains("--gc:orc"), "Should use ORC GC");
-    assert!(!rendered_js.contains("--app:lib"), "JS target should not use --app:lib");
+    assert!(
+        !rendered_js.contains("--app:lib"),
+        "JS target should not use --app:lib"
+    );
 
     // Test CPP + None GC
     let dir3 = TempDir::new().unwrap();
@@ -306,9 +319,15 @@ opt-level = "size"
     let m_cpp = manifest::load_manifest(&path_cpp).unwrap();
     let cmd_cpp = build_gen::build_command_from_manifest(&m_cpp, "cpp_lib.nim", true);
     let rendered_cpp = cmd_cpp.render();
-    assert!(rendered_cpp.starts_with("nim cpp"), "CPP backend should use 'nim cpp'");
+    assert!(
+        rendered_cpp.starts_with("nim cpp"),
+        "CPP backend should use 'nim cpp'"
+    );
     assert!(rendered_cpp.contains("--gc:none"), "Should use no GC");
-    assert!(rendered_cpp.contains("--opt:size"), "Should optimise for size");
+    assert!(
+        rendered_cpp.contains("--opt:size"),
+        "Should optimise for size"
+    );
 }
 
 // ---------------------------------------------------------------------------
@@ -330,7 +349,10 @@ fn test_init_creates_valid_manifest() {
     manifest::validate(&m).expect("Generated manifest should be valid");
 
     assert!(!m.project.name.is_empty());
-    assert!(m.functions.len() >= 2, "Template should have example functions");
+    assert!(
+        m.functions.len() >= 2,
+        "Template should have example functions"
+    );
 }
 
 // ---------------------------------------------------------------------------