Skip to content

docs: restore README.md lost in Floor Raise campaign - #6

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/restore-readme
Mar 28, 2026
Merged

docs: restore README.md lost in Floor Raise campaign#6
hyperpolymath merged 1 commit into
mainfrom
fix/restore-readme

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

  • Restores the original README.md that was replaced with a 5-line AsciiDoc stub during the Floor Raise campaign
  • Removes the stub README.adoc

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 3e1beca into main Mar 28, 2026
13 of 15 checks passed
@hyperpolymath
hyperpolymath deleted the fix/restore-readme branch March 28, 2026 02:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac247f63db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
Comment on lines +15 to +16
- `divide(a, b)` - Division
- `modulo(a, b)` - Modulo (integer operation)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document only APIs that are actually implemented

The README now advertises functions like divide/2, modulo/2, greater_than/2, not_equal/2, and greater_equal/2, but these are not defined in the current library modules (lib/arithmetic.ex and lib/comparison.ex), so users following this documentation will hit UndefinedFunctionError. Please either remove these entries or implement the APIs before documenting them.

Useful? React with 👍 / 👎.

Comment thread README.md
```elixir
def deps do
[
{:polyglot_formalisms, "~> 0.2.0"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align dependency snippet with project version metadata

The installation example pins {:polyglot_formalisms, "~> 0.2.0"} while mix.exs declares the project as version 0.3.0; this mismatch encourages consumers to install an older release than the codebase being documented and can lead to API/docs drift for new users.

Useful? React with 👍 / 👎.

Comment thread README.md
This implementation follows BEAM/Erlang semantics:

### Float Operations
- Division by zero returns `Infinity` or `-Infinity`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix incorrect float division-by-zero semantics

The behavioral section claims division by zero returns Infinity/-Infinity, but in Elixir/BEAM 1.0 / 0.0 raises ArithmeticError; documenting the opposite behavior can cause incorrect exception handling assumptions in downstream code.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant