Skip to content

Commit 1491828

Browse files
ci(antipattern): broaden TS allowlist (cli, mod.ts, lsp-server, *vscode*, deno-*) (#9)
Follow-up to the first allowlist patch — adds: - `/cli/` (CLI entry points) - `mod.ts` (canonical Deno module entrypoint) - `lsp-server.ts`, `*-lsp.ts` (LSP servers) - broader `*vscode*` (was `/vscode/` only — now covers `vscode-extension/`, `extensions/vscode/`, etc.) - `/deno-*/` (subprojects explicitly named for Deno) Estate-wide re-survey showed these patterns dominate the false-positive set.
1 parent 6f98da6 commit 1491828

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

.github/workflows/rsr-antipattern.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,16 @@ jobs:
2020
- name: Check for TypeScript
2121
run: |
2222
# Allowlist (TS legitimate as a bridge/adapter to a non-ReScript ecosystem):
23-
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI to ReScript core)
24-
# *.d.ts - TypeScript type declarations for ReScript FFI
25-
# tests/, test/ - Deno test runners verifying ReScript output
26-
# scripts/ - Deno build scripts (bundle, dev-server, etc.)
27-
# mcp-adapter/ - MCP server adapters (MCP protocol is Deno/TS-typed by spec)
28-
# vscode/ - VSCode extensions (TS is the ecosystem default)
23+
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI)
24+
# *.d.ts - TypeScript type declarations for ReScript FFI
25+
# tests/, test/ - Deno test runners
26+
# scripts/ - Deno build scripts
27+
# mcp-adapter/ - MCP server adapters (MCP is Deno/TS-typed by spec)
28+
# *vscode* - VSCode extensions (TS is the ecosystem default)
29+
# cli/ - CLI entry points (Deno scripts)
30+
# mod.ts - canonical Deno module entrypoint
31+
# *lsp-server.ts, *lsp.ts - Language Server Protocol implementations
32+
# deno-*/ - subprojects explicitly named for Deno
2933
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) \
3034
| grep -v node_modules \
3135
| grep -v '/bindings/' \
@@ -34,7 +38,12 @@ jobs:
3438
| grep -v '/test/' \
3539
| grep -v '/scripts/' \
3640
| grep -v '/mcp-adapter/' \
37-
| grep -v '/vscode/' \
41+
| grep -Ev '/[^/]*vscode[^/]*/' \
42+
| grep -v '/cli/' \
43+
| grep -v '/mod\.ts$' \
44+
| grep -Ev 'lsp[-_]?server\.ts$' \
45+
| grep -Ev '[/-]lsp\.ts$' \
46+
| grep -Ev '/deno-[^/]+/' \
3847
|| true)
3948
if [ -n "$TS_FILES" ]; then
4049
echo "❌ TypeScript files detected - use ReScript instead"

0 commit comments

Comments
 (0)