Skip to content

fix(ci): complete Ast import removal in verification/mod.rs and cargo fmt across crate#44

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/rust-ci-mod-rs-ast
May 12, 2026
Merged

fix(ci): complete Ast import removal in verification/mod.rs and cargo fmt across crate#44
hyperpolymath merged 2 commits into
mainfrom
fix/rust-ci-mod-rs-ast

Conversation

@hyperpolymath
Copy link
Copy Markdown
Owner

Summary

Closes the remaining Rust CI red on main after #43 (steamworks 0.12.2 → 0.13.1):

  • coverage job was still failing with error: unused import: Ast at src/verification/mod.rs:81. The fix-up commit 9435baa removed the same import from src/verification/z3_integration.rs but missed this second occurrence. Removed.
  • test job was exit-1-ing on cargo fmt --check. Ran cargo fmt --all across the crate — 12 files reformatted, no semantic change (struct-literal expansion + use-ordering).

The security job was cancelled by an Actions runner shutdown signal during the cargo-outdated install — looks transient, not code-related, and should pass on rerun.

Test plan

  • cargo fmt --all -- --check clean.
  • cargo build --features z3-verify succeeds.
  • coverage, test, and security Rust CI jobs go green on this branch.

… fmt across crate

The previous fix-up commit (9435baa) removed `use z3::ast::{Ast, Bool};` from
`src/verification/z3_integration.rs` but missed the identical line at
`src/verification/mod.rs:81`. The coverage job (which builds with
`--features z3-verify`) still hit `-D unused-imports` on it and failed.

This commit:
- Removes the surviving unused `Ast` import in `src/verification/mod.rs`.
- Runs `cargo fmt --all` to clear the formatter diff the `test` job was
  exit-1-ing on (12 files, mostly struct-literal expansion + use-ordering;
  no semantic change).

The `security` job was cancelled by a runner shutdown signal during the
cargo-outdated install — likely transient runner timeout, not a code issue,
and should pass once re-run.
The SHA 65c79d7... no longer resolves; actions/upload-artifact v4 now
points to ea165f8d. This was the root cause of every Hypatia Security
Scan red across the estate (tracked in hyperpolymath/hypatia#213).
hyperpolymath added a commit to hyperpolymath/v3-templater that referenced this pull request May 12, 2026
…covered from #57) (#58)

Recovery cherry-pick of the bump from closed PR #57. The original PR was
closed under the rationale that estate-wide CI failures dominated its
red marks — that was correct about the failures being systemic, but
closing the bump itself stranded the dependency update. Reapplying.

The systemic CI cause ( SHA no longer resolves) is being fixed
separately; see hyperpolymath/proof-of-work#44 and
hyperpolymath/affinescript-vite#9.

🤖 Recovered by Claude Code.
@hyperpolymath hyperpolymath merged commit ce3c597 into main May 12, 2026
16 of 25 checks passed
@hyperpolymath hyperpolymath deleted the fix/rust-ci-mod-rs-ast branch May 12, 2026 20:36
Repository owner deleted a comment from chatgpt-codex-connector Bot May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant