Commit c54d0c3
## Summary
Addresses the source-fixable half of #145. Adds a dedicated
**`proof-check`** job to `idris2-ci.yml` that type-checks **every**
`src/**/Proofs.idr` (glob-discovered, so new proof files are
auto-covered) with `idris2 -p contrib -p network --check`, running in
parallel with the slow full `build`.
## Why
#127's swapped-arg `appendLengthInc` (`lengthSnoc arr v` — but contrib
`lengthSnoc` is element-first) failed to type-check and blocked the
**entire** `SafeJson.Proofs` module, yet reached `main`. Two gaps let it
through:
1. The only job compiling proof modules was the full `idris2 --build
proven.ipkg` (~12-20 min warm) — manual merges routinely outrace it
while it sits `queued`.
2. The explicit per-module `--check` list in `idris2-ci.yml` covered
**zero** `Proofs.idr` files — exactly the modules the Phase-3 discharge
campaign edits each PR.
## What it does
- New `proof-check` job: globs `find src -name 'Proofs.idr'`, checks
each, emits `::error file=…::` annotations, fails if any fail.
- Caches only the Idris2 compiler; **never** `idris2 --install
proven.ipkg`, **never** caches `build/` — so a stale cache cannot mask a
source-level break.
- Documents the decision as **ADR-004** in `META.a2ml`.
## Remaining (admin, tracked in #145)
This job is necessary but not sufficient. Closing the gate needs
`proof-check` made a **required status check** on `main` via branch
protection — only the repo admin can toggle that. Until then, "merged"
still doesn't imply "CI passed" under the solo-admin-merge posture.
## Verification
- Both files parse (`yaml.safe_load` → jobs `build, proof-check, docs`;
`tomllib` → ADR-001..004).
- The `Proofs.idr` check loop was validated locally on a clean
idris2-0.8.0 + contrib install (SafeJson/SafeMath/SafeString proof
cones, 0 errors).
- This PR touches `idris2-ci.yml`, which is in the CI path filter — so
the new `proof-check` job runs on this PR and proves itself before
merge.
Refs #145, #144, #127.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01MN5vzRR4MK2dkDNaHqqRDy)_
Co-authored-by: Claude <noreply@anthropic.com>
1 parent dc1502f commit c54d0c3
1 file changed
Lines changed: 70 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
97 | 167 | | |
98 | 168 | | |
99 | 169 | | |
| |||
0 commit comments