fix(d,ci): D nothrow compile fix + Trustfile gate accepts CC-BY-SA-4.0 docs#175
Merged
Merged
Conversation
…in Trustfile gate Two pre-existing proven CI failures (surfaced once #174 unblocked d-build): D nothrow (d-build compile): parseHexColor/parseCurrency/parseIsoDateTime/parsePhone/parseUrl are marked 'nothrow' but called the *Result.success/.failure factory methods, which were not nothrow -> ldc2 errors. Those factories only construct and return a struct (no throwing ops), so marking the 10 methods 'nothrow' is correct and minimal. Trustfile 'Enforce Trustfile Policies' gate: The SPDX check required MPL-2.0 on every file under src/ffi/bindings, flagging 27 documentation READMEs that correctly carry CC-BY-SA-4.0 (estate docs licence). Changed the gate to accept either MPL-2.0 (code) or CC-BY-SA-4.0 (docs) and flag only headers that are neither -- still catches stray PMPL/Apache/etc. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SuLNP87x3i5YXdq2wYERRK
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two pre-existing proven CI failures that #174 surfaced (and which were out of #174's pin-scope).
1.
d-buildcompile — DnothrowviolationsparseHexColor/parseCurrency/parseIsoDateTime/parsePhone/parseUrlare markednothrow, but called the*Result.success/.failurefactory methods, which were notnothrow→ldc2errors. Those factories only construct and return a struct (no throwing operations), so marking all 10 methodsnothrowis the correct, minimal fix (acrosssafe_{color,currency,datetime,phone,url}.d).2.
Enforce Trustfile Policies— SPDX gate vs docs licenceThe gate required
MPL-2.0on every file undersrc/ffi/bindings, flagging 27 README docs that correctly carryCC-BY-SA-4.0(the estate docs licence). Changed it to accept eitherMPL-2.0(code) orCC-BY-SA-4.0(docs), flagging only headers that are neither — so it still catches stray PMPL/Apache/etc.Verification
nothrowfix is sound by construction (factory bodies do only struct construction); I couldn't runldc2in this environment, so CI'sd-buildis the final confirmation.Note
The pre-existing Hypatia
scan/Validate Hypatia Baselinereds are not addressed here (scanner-dependent, owner-territory) and remain as on standards.🤖 Generated with Claude Code
Generated by Claude Code