Skip to content

chore: remove obsolete/corrupted check-no-vlang.sh gate - #18

Merged
hyperpolymath merged 4 commits into
mainfrom
chore/remove-obsolete-vlang-check
Jul 27, 2026
Merged

chore: remove obsolete/corrupted check-no-vlang.sh gate#18
hyperpolymath merged 4 commits into
mainfrom
chore/remove-obsolete-vlang-check

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Removes the estate's scripts/check-no-vlang.sh gate and the CI step that
invoked it.

Why

V (vlang.io) was banned from the estate years ago. check-no-vlang.sh was
written to enforce that ban. At some point a global search-and-replace ran
"V" -> "zig" across the file and it now bans Zig instead -- Zig is the
estate's primary systems/FFI language (Zig-first ABI/FFI doctrine), so this
script has been silently failing CI for any repo that legitimately touches
Zig, and is worthless as a V-lang check now that "V" no longer appears in it.

Evidence of the corruption (from the script's own comments before removal):

  • check-no-vlang.sh — enforce "ziguage is banned in the estate". (i.e. "V
    language" got replaced with "ziguage")
  • Estate rule: zig (vlang.io) is banned. (vlang.io is V's site, not Zig's)
  • PATTERNS=( ... 'zig' 'zig' 'vlang' ... ) (a duplicated replacement)
  • failure message: zig has been replaced by zig-unified-api-adapter.

V is long retired from the estate and this check is obsolete either way, so
rather than fix the corrupted pattern list, this PR deletes the script and
its CI step outright.

What changed

  • git rm scripts/check-no-vlang.sh
  • Removed the "No zig references" / "No V-lang references" step from the
    CI workflow that invoked it (job/workflow otherwise untouched).

No other files were modified.

🤖 Generated with Claude Code

hyperpolymath and others added 2 commits July 27, 2026 18:38
V (vlang.io) was banned from the estate long ago and check-no-vlang.sh
enforced that. A prior global search-and-replace rewrote "V" -> "zig"
throughout the script, so it now bans Zig -- the estate's primary
systems/FFI language -- instead of V. Delete the script and the CI step
that invoked it; V is long gone either way so there is nothing left to
enforce.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath marked this pull request as ready for review July 27, 2026 18:25
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 18:29
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 18:43
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 18:46
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 18:52
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 19:04
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 19:30
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 19:44
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 19:58
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 58f1c51 into main Jul 27, 2026
24 of 25 checks passed
@hyperpolymath
hyperpolymath deleted the chore/remove-obsolete-vlang-check branch July 27, 2026 21:01
@gitar-bot

gitar-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
CI failed: CI build failure caused by new root entries (`LICENSES/` and `flake.nix`) that are missing from the allowlist in `.machine_readable/root-allow.txt`.

Overview

The CI build failed across 2 jobs because the root-shape check script detected new unallowed entries in the repository root (LICENSES/ and flake.nix). This is directly related to the repository structure and the changes made.

Failures

Root Shape Check Failure (confidence: high)

  • Type: build
  • Affected jobs: 90106877901, 90107035636
  • Related to change: yes
  • Root cause: The script scripts/check-root-shape.sh . detected two root entries (LICENSES/ and flake.nix) that are not present in .machine_readable/root-allow.txt or the appropriate subdirectories.
  • Suggested fix: Add LICENSES/ and flake.nix to .machine_readable/root-allow.txt or move them into the appropriate subdirectory.

Summary

  • Change-related failures: 2 jobs failed due to unallowed repository root entries (LICENSES/ and flake.nix).
  • Infrastructure/flaky failures: None.
  • Recommended action: Update .machine_readable/root-allow.txt to include LICENSES/ and flake.nix, or relocate them to a permitted subdirectory.
Code Review ✅ Approved

Removes the obsolete and corrupted check-no-vlang.sh gate along with its corresponding CI step. No issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant