Skip to content

fix: allow REUSE LICENSES/ dir in root-shape allowlist - #20

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/root-allow-licenses
Jul 27, 2026
Merged

fix: allow REUSE LICENSES/ dir in root-shape allowlist#20
hyperpolymath merged 3 commits into
mainfrom
fix/root-allow-licenses

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • check-root-shape.sh was rejecting LICENSES/, the directory REUSE compliance mandates for licence texts.
  • .machine_readable/root-allow.txt never listed it, so a correctly-REUSE-compliant repo was being flagged as root drift.
  • Adds the canonical allowlist entry, copied verbatim from the already-fixed reference at this-ssg.

Test plan

  • bash scripts/check-root-shape.sh . no longer flags LICENSES/
  • Only .machine_readable/root-allow.txt touched (1 line added)

🤖 Generated with Claude Code


Summary by Gitar

  • Configurations: - Added flake.nix to .machine_readable/root-allow.txt pending Nix-retirement decision

This will update automatically on new commits.

check-root-shape.sh was rejecting the REUSE-mandated LICENSES/ directory
as root drift because .machine_readable/root-allow.txt never listed it.
Add the canonical entry (matching the already-fixed this-ssg reference).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath marked this pull request as ready for review July 27, 2026 19:05
@hyperpolymath
hyperpolymath enabled auto-merge (squash) July 27, 2026 19:05
@hyperpolymath
hyperpolymath disabled auto-merge July 27, 2026 19:59
Same fix as bitfuckit: the root-shape gate failed on flake.nix alone. Nix was
retired estate-wide 2026-06-01, but removing the file is a policy decision
(backlog A), not something a CI-unblocking PR should make. Allowlisted with an
explicit TOLERATED-NOT-BLESSED comment so the decision is recorded, not made.

Verified locally: check-root-shape.sh exits 0 clean, exits 1 with a probe file.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit a622e08 into main Jul 27, 2026
22 of 23 checks passed
@hyperpolymath
hyperpolymath deleted the fix/root-allow-licenses branch July 27, 2026 21:00
@gitar-bot

gitar-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
CI failed: CI failures in openssf-compliance due to unfilled placeholder tokens, docs check due to an unapproved markdown file, and K9 contract validation due to license files being scanned.

Overview

Multiple CI jobs failed across compliance, documentation format, and contract validation checks due to policy violations and files incorrectly included in validation scopes (total 4 logs analyzed across 3 unique failure patterns).

Failures

Openssf-Compliance Placeholder Check Failed (confidence: high)

  • Type: test
  • Affected jobs: 90106402319
  • Related to change: unclear
  • Root cause: File .machine_readable/6a2/STATE.a2ml contains 2 unfilled {{PLACEHOLDER}} tokens, violating the OpenSSF compliance rule.
  • Suggested fix: Run just init or manually replace the placeholder tokens in .machine_readable/6a2/STATE.a2ml.

Documentation Format Policy Violation (confidence: high)

  • Type: tooling
  • Affected jobs: 90106402280, 90106845947
  • Related to change: yes
  • Root cause: A Markdown file (docs/tech-debt-2026-05-26.md) was added under docs/, violating the repository policy requiring AsciiDoc (.adoc) by default.
  • Suggested fix: Convert docs/tech-debt-2026-05-26.md to AsciiDoc (.adoc) or add an entry to the ALLOWED list in scripts/check-no-md-in-docs.sh.

K9 Contract Validation Failed (confidence: high)

  • Type: test
  • Affected jobs: 90106403383
  • Related to change: yes
  • Root cause: The K9 validator scanned files under the REUSE LICENSES/ directory that lack required K9 magic numbers and pedigree blocks.
  • Suggested fix: Exclude the license/REUSE directory from K9 contract validation in the workflow or ignore paths configuration.

Summary

  • Change-related failures: 2 failures related to documentation format policy and K9 contract validation scope.
  • Infrastructure/flaky failures: 0 failures.
  • Recommended action: Convert the markdown doc to AsciiDoc (or whitelist it), update the K9 validation ignore paths to exclude REUSE LICENSES/, and fill in any required placeholder tokens in machine-readable files.
Code Review ✅ Approved

Adds the LICENSES/ directory and flake.nix to the root-shape allowlist to prevent REUSE compliance and Nix configuration from being flagged as root drift. No issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant