fix(ci): three CI blockers — dead rsr-antipattern ref, K9 gap, unfinished instantiation - #21
Conversation
…ation Three independent CI-blocker fixes bundled together (verified individually, listed by check name): lint-workflows: rsr-antipattern.yml called a reusable workflow (rsr-antipattern-reusable.yml) that has never existed on hyperpolymath/standards — confirmed via the commits API and absent from the current rsr-template-repo. Per docs/audits/audit-reusables-convergence-2026-05-26.adoc, `antipattern- check` was retired estate-wide; its function is already covered by governance.yml -> governance-reusable.yml (already wired here). No SHA exists to pin against a file that was never committed, so the fix is to delete the dead workflow. Validate K9 contracts: locally reproduced the reported 8 errors / 10 files. 6 of 8 were a shared-validator scope bug (coordination.k9, session/custom-checks.k9, self-validating/methodology-guard.k9.ncl aren't K9 pedigree contracts at all) fixed at the source in hyperpolymath/k9-ecosystem#21, with a local paths-ignore override here as a stopgap since this repo pins the action to a commit SHA. The remaining 2 were a genuine container/deploy.k9.ncl defect: missing the literal `K9!` first line, and `pedigree` pointed at a let-bound variable instead of an inline block, hiding name/version/leash from the validator's line-based scanner. Fixed by adding the magic line and merging the required fields inline. openssf-compliance: "Check no unfilled placeholder tokens" failed on TWO files. .machine_readable/6a2/ECOSYSTEM.a2ml's `notes` field documented the {{PLACEHOLDER}} substitution mechanism using the literal token shape (reworded, same false-positive class as hypatia#243). .machine_readable/6a2/STATE.a2ml was still, despite PR #19's title ("instantiate recon-silly-ation from the RSR template"), substantively the raw rsr-template-repo template: `project = "rsr-template-repo"`, a "META-TEMPLATE" preamble describing itself as "the STATE file for rsr-template-repo itself", milestones/maturity describing the template's own 95%-complete state, and a "NOTE FOR CONSUMERS" instantiation-instructions block. Properly instantiated for recon-silly-ation (name, purpose, phase/maturity, milestones, next-actions) using its own README.adoc/0-AI-MANIFEST.a2ml as source of truth, matching the shape already used by bitfuckit's STATE.a2ml. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
CI failed: CI root shape validation failed because LICENSES/ and flake.nix are present in the repository root without being listed in the allowlist.OverviewRoot shape validation check failed during CI execution due to unauthorized files/directories in the repository root. FailuresRoot Shape Validation Failure (confidence: high)
Summary
Code Review ✅ Approved 1 resolved / 1 findingsRemoves the dead rsr-antipattern reference, fixes K9 contract validation errors, and properly instantiates STATE.a2ml. Consider addressing the duplicated identity fields in the inline pedigree merge to prevent drift.
✅ 1 resolved✅ Quality: Duplicated identity fields can drift out of sync
Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
1 participant
Summary
Fixes the three CI blockers keeping the estate's PR queue stuck, as
diagnosed for this repo (full per-blocker root-cause detail is in the
commit message):
rsr-antipattern.yml:15): thereferenced reusable (
rsr-antipattern-reusable.yml) has neverexisted on
hyperpolymath/standards. It's dead, retired estate-wideper
docs/audits/audit-reusables-convergence-2026-05-26.adoc, andsuperseded by
governance.yml(already present here). Deletedrather than pinned to an unresolvable reference.
k9-ecosystem/validate-actionscope bug, fixed at the source infix(validate-action): exclude non-pedigree files from K9 checks k9-ecosystem#21 (with a local stopgap override here).
The remaining 2 were a genuine
container/deploy.k9.ncldefect(missing
K9!line, pedigree hidden behind a let-binding) — fixeddirectly.
ECOSYSTEM.a2ml'snotesfield documented the{{PLACEHOLDER}}mechanism using theliteral token shape (reworded).
STATE.a2mlwas still, despitePR fix: instantiate recon-silly-ation from the RSR template #19's title, substantively the raw template —
project = "rsr-template-repo", a "STATE file for rsr-template-repo itself"preamble, and template-authoring milestones/notes. Properly
instantiated for recon-silly-ation from its own README/manifest.
Test plan
bash validate-action/validate-k9.sh(k9-ecosystem, with thenew paths-ignore) →
Errors: 0(was 8)grep -rnE '^[[:space:]]+uses:' .github/workflows/ | grep -v '@[a-f0-9]{40}'→ empty (was 1 match)
→ 0 files flagged (was 2)
python3 -c "import tomllib; tomllib.load(...)"on the edited.a2mlfiles → parses cleanyaml.safe_load🤖 Generated with Claude Code