Skip to content

Commit 7fdaca7

Browse files
ci(scorecard-enforcer): split score-threshold from publish job (#23)
Replace local copy with the post-#304 standards template. The pre-fix shape has the OSSF publish contract violation: webapp: scorecard job must only have steps with uses Post-fix shape: - `scorecard` job: uses-only (now includes upload-artifact for SARIF hand-off) - `check-score` job: `needs: scorecard`, downloads artifact, runs threshold gate Caught 49 estate repos on the 2026-05-30 audit. Detector: hypatia rule WF014. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 055a484 commit 7fdaca7

1 file changed

Lines changed: 37 additions & 2 deletions

File tree

.github/workflows/scorecard-enforcer.yml

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,28 @@ on:
99
- cron: '0 6 * * 1' # Weekly on Monday
1010
workflow_dispatch:
1111

12+
# Estate guardrail: cancel superseded runs so re-pushes / rebased PR
13+
# updates do not pile up queued runs against the shared account-wide
14+
# Actions concurrency pool. Applied only to read-only check workflows
15+
# (no publish/mutation), so cancelling a superseded run is always safe.
16+
concurrency:
17+
group: ${{ github.workflow }}-${{ github.ref }}
18+
cancel-in-progress: true
19+
1220
permissions:
1321
contents: read
1422

1523
jobs:
24+
# The OSSF Scorecard publish endpoint enforces a hard contract: the job that
25+
# runs `ossf/scorecard-action` with `publish_results: true` must contain
26+
# ONLY steps with `uses:` (no `run:` steps in the same job). If a `run:`
27+
# step is present, the publish step fails with:
28+
# "webapp: scorecard job must only have steps with uses"
29+
# (49 estate repos hit this; see ROADMAP audit 2026-05-30.)
30+
#
31+
# Fix: split the threshold check into a downstream job that depends on
32+
# `scorecard` and consumes the SARIF artifact. The `scorecard` job stays
33+
# uses-only; `check-score` is the gating job that emits the error.
1634
scorecard:
1735
runs-on: ubuntu-latest
1836
permissions:
@@ -31,13 +49,30 @@ jobs:
3149
publish_results: true
3250

3351
- name: Upload SARIF
34-
uses: github/codeql-action/upload-sarif@0d579ffd059c29b07949a3cce3983f0780820c98 # v4
52+
uses: github/codeql-action/upload-sarif@c6f931105cb2c34c8f901cc885ba1e2e259cf745 # v4
3553
with:
3654
sarif_file: results.sarif
3755

56+
- name: Persist SARIF for downstream score-gate job
57+
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
58+
with:
59+
name: scorecard-results
60+
path: results.sarif
61+
retention-days: 1
62+
63+
check-score:
64+
needs: scorecard
65+
runs-on: ubuntu-latest
66+
permissions:
67+
contents: read
68+
steps:
69+
- name: Download SARIF from scorecard job
70+
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v5.0.0
71+
with:
72+
name: scorecard-results
73+
3874
- name: Check minimum score
3975
run: |
40-
# Parse score from results
4176
SCORE=$(jq -r '.runs[0].tool.driver.properties.score // 0' results.sarif 2>/dev/null || echo "0")
4277
4378
echo "OpenSSF Scorecard Score: $SCORE"

0 commit comments

Comments
 (0)