Skip to content

Commit a3a2f32

Browse files
committed
fix(rust-ci): pass explicit toolchain: stable to SHA-pinned dtolnay action
The reusable Rust CI bundle pins `dtolnay/rust-toolchain` by commit SHA (`@67ef31d5…`). That action infers the toolchain from its `@`-ref (e.g. `@stable`), but a SHA ref carries no version, so its "parse toolchain version" step receives an empty `toolchain` and fails: 'toolchain' is a required input Process completed with exit code 1 This is the estate-wide `rust-ci / Cargo check + clippy + fmt` red seen on every PR across the ~28 repos consuming this reusable workflow (confirmed live in iseriser run 28287559313). Add `toolchain: stable` to all four `dtolnay/rust-toolchain` steps (check, test, audit, coverage), matching the `# stable` pin comment. Consumers inherit the fix on the next standards-reusable pin refresh. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
1 parent 583a934 commit a3a2f32

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

.github/workflows/rust-ci-reusable.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,14 @@ jobs:
149149
ref: ${{ github.ref }}
150150

151151
- name: Install Rust toolchain
152+
# `toolchain:` is mandatory because the action is pinned by commit SHA:
153+
# dtolnay/rust-toolchain infers the toolchain from the `@`-ref (e.g.
154+
# `@stable`), but a SHA ref carries no version, so the action's "parse
155+
# toolchain version" step fails with `'toolchain' is a required input`.
156+
# See standards estate-wide rust-ci red.
152157
uses: dtolnay/rust-toolchain@67ef31d5b988238dd797d409d6f9574278e20537 # stable
153158
with:
159+
toolchain: stable
154160
components: clippy, rustfmt
155161

156162
- name: Cache cargo registry and build
@@ -190,7 +196,10 @@ jobs:
190196
ref: ${{ github.ref }}
191197

192198
- name: Install Rust toolchain
199+
# `toolchain:` mandatory under SHA pin — see Cargo check job above.
193200
uses: dtolnay/rust-toolchain@67ef31d5b988238dd797d409d6f9574278e20537 # stable
201+
with:
202+
toolchain: stable
194203

195204
- name: Cache cargo registry and build
196205
uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2
@@ -230,7 +239,10 @@ jobs:
230239
ref: ${{ github.ref }}
231240

232241
- name: Install Rust toolchain
242+
# `toolchain:` mandatory under SHA pin — see Cargo check job above.
233243
uses: dtolnay/rust-toolchain@67ef31d5b988238dd797d409d6f9574278e20537 # stable
244+
with:
245+
toolchain: stable
234246

235247
- name: Install cargo-audit
236248
# Use the binstall path when available to skip a from-source rebuild
@@ -260,7 +272,10 @@ jobs:
260272
ref: ${{ github.ref }}
261273

262274
- name: Install Rust toolchain
275+
# `toolchain:` mandatory under SHA pin — see Cargo check job above.
263276
uses: dtolnay/rust-toolchain@67ef31d5b988238dd797d409d6f9574278e20537 # stable
277+
with:
278+
toolchain: stable
264279

265280
- name: Install tarpaulin
266281
run: cargo install cargo-tarpaulin --locked

0 commit comments

Comments
 (0)