Skip to content

security: rust-secrets — require assignment to a literal, and cover static #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Jul 21, 2026
Merged

security: rust-secrets — require assignment to a literal, and cover static #523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
766156c
security: rust-secrets — require assignment to a literal, and cover `…
hyperpolymath Jul 21, 2026
0db2544
Merge branch 'main' into security/rust-secrets-literal-assignment
hyperpolymath Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions .github/workflows/secret-scanner-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,25 @@ jobs:
fi
echo "Scanning ${#FILES[@]} Rust file(s)."

# Each pattern requires an assignment DIRECTLY to a string literal of
# meaningful length. The previous forms matched `= ... "` — a quote
# anywhere after an equals — which flagged code that hardcodes
# nothing at all. Measured across the 64 Rust repos in the estate
# sweep, every one of these was a false positive:
# let api_key = request["api_key"].as_str().unwrap_or("") (lookup)
# let api_key_file = temp_dir.path().join("config.js") (path)
# Query::new("Here's my api_key=sk-12345") (a demo)
# A credential shorter than 8 characters is not a credential either.
# `static` is accepted alongside `const`: the old `const.*KEY` form
# missed `static AUTH_KEY: &str = "…"`, a genuine hardcoded secret
# (caught by canary, not by inspection).
PATTERNS=(
'const.*SECRET.*=.*"'
'const.*KEY.*=.*"[a-zA-Z0-9]{16,}"'
'const.*TOKEN.*=.*"'
'let.*api_key.*=.*"'
'(const|static)[[:space:]]+(mut[[:space:]]+)?[A-Za-z0-9_]*SECRET[A-Za-z0-9_]*[[:space:]]*(:[^=]*)?=[[:space:]]*b?"[^"]{8,}"'
'(const|static)[[:space:]]+(mut[[:space:]]+)?[A-Za-z0-9_]*KEY[A-Za-z0-9_]*[[:space:]]*(:[^=]*)?=[[:space:]]*b?"[a-zA-Z0-9]{16,}"'
'(const|static)[[:space:]]+(mut[[:space:]]+)?[A-Za-z0-9_]*TOKEN[A-Za-z0-9_]*[[:space:]]*(:[^=]*)?=[[:space:]]*b?"[^"]{8,}"'
'(let|static)[[:space:]]+(mut[[:space:]]+)?[a-z0-9_]*api_key[a-z0-9_]*[[:space:]]*(:[^=]*)?=[[:space:]]*b?"[^"]{8,}"'
'HMAC.*"[a-fA-F0-9]{32,}"'
'password.*=.*"[^"]+"'
'[a-z0-9_]*password[a-z0-9_]*[[:space:]]*(:[^=]*)?=[[:space:]]*b?"[^"]{8,}"'
)

# Exemptions, mirroring the four layers already documented on
Expand Down
Loading